From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3st1JF3JZ6zDrbk for ; Tue, 11 Oct 2016 00:32:12 +1100 (AEDT) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u9ADTWhu098584 for ; Mon, 10 Oct 2016 09:32:10 -0400 Received: from e35.co.us.ibm.com (e35.co.us.ibm.com [32.97.110.153]) by mx0b-001b2d01.pphosted.com with ESMTP id 260bwgg3u3-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 10 Oct 2016 09:32:10 -0400 Received: from localhost by e35.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 10 Oct 2016 07:32:09 -0600 Subject: Re: [PATCH v7 3/6] perf annotate: Show raw form for jump instruction with indirect target To: Arnaldo Carvalho de Melo References: <1474472876-2706-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <1474472876-2706-4-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20161005112701.GS7143@kernel.org> Cc: linux-kernel@vger.kernel.org, kim.phillips@arm.com, linuxppc-dev@lists.ozlabs.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, treeze.taeung@gmail.com, naveen.n.rao@linux.vnet.ibm.com, markus@trippelsdorf.de, namhyung@kernel.org, pawel.moll@arm.com, chris.ryder@arm.com, jolsa@kernel.org, mhiramat@kernel.org, Ravi Bangoria From: Ravi Bangoria Date: Mon, 10 Oct 2016 19:01:55 +0530 MIME-Version: 1.0 In-Reply-To: <20161005112701.GS7143@kernel.org> Content-Type: text/plain; charset=windows-1252 Message-Id: <57FB984B.1090901@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wednesday 05 October 2016 04:57 PM, Arnaldo Carvalho de Melo wrote: > Em Wed, Sep 21, 2016 at 09:17:53PM +0530, Ravi Bangoria escreveu: >> For jump instructions that does not include target address as direct >> operand, use raw value for that. This is needed for certain powerpc > "use raw value" looks vague, as the example below makes is go from > using a value (ffffffffffffca2c) to no value at all, i.e. the output > looks backwards from what you describe, can you instead show the > original disassembled line from objdump, which I think is what you're > calling "raw value" in this case? Correct, I'm showing that only -- "original disassembled line from objdump". There is no direct operand with bctr. It uses content of register 'ctr' as target address. For example, objdump output: 100b8fd8: add r10,r9,r10 100b8fdc: mtctr r10 100b8fe0: bctr > - Arnaldo > >> jump instructions that use target address in a register (such as bctr, >> btar, ...). >> >> Before: >> ld r12,32088(r12) >> mtctr r12 >> v bctr ffffffffffffca2c >> std r2,24(r1) >> addis r12,r2,-1 >> >> After: >> ld r12,32088(r12) >> mtctr r12 >> v bctr >> std r2,24(r1) >> addis r12,r2,-1 >> >> Suggested-by: Michael Ellerman >> Signed-off-by: Ravi Bangoria >> --- >> Changes in v7: >> - Added example in description >> >> tools/perf/util/annotate.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c >> index 5aa72d9..1ccf26a 100644 >> --- a/tools/perf/util/annotate.c >> +++ b/tools/perf/util/annotate.c >> @@ -136,6 +136,9 @@ static int jump__parse(struct ins_operands *ops, struct map *map __maybe_unused) >> static int jump__scnprintf(struct ins *ins, char *bf, size_t size, >> struct ins_operands *ops) >> { >> + if (!ops->target.addr) >> + return ins__raw_scnprintf(ins, bf, size, ops); >> + >> return scnprintf(bf, size, "%-6.6s %" PRIx64, ins->name, ops->target.offset); >> } >> >> -- >> 2.5.5