From: Haren Myneni <haren@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: herbert@gondor.apana.org.au, ddstreet@ieee.org,
linuxppc-dev@lists.ozlabs.org, linux-crypto@vger.kernel.org,
benh@kernel.crashing.org, mikey@neuling.org, suka@us.ibm.com,
hbabu@us.ibm.com
Subject: Re: [PATCH 1/5] crypto/nx: Rename nx842_powernv_function as icswx function
Date: Tue, 04 Apr 2017 20:32:05 -0700 [thread overview]
Message-ID: <58E46535.5080108@linux.vnet.ibm.com> (raw)
In-Reply-To: <87inmkv348.fsf@concordia.ellerman.id.au>
On 04/04/2017 04:11 AM, Michael Ellerman wrote:
> Haren Myneni <haren@linux.vnet.ibm.com> writes:
>
>> [PATCH 1/5] crypto/nx: Rename nx842_powernv_function as icswx function
>>
>> nx842_powernv_function is points to nx842_icswx_function and
>> will be point to VAS function which will be added later for
>> P9 NX support.
>
> I know it's nit-picking but can you give it a better name while you're
> there.
>
> I was thinking it should be called "send" or something, but it actually
> synchronously sends and waits for a request.
>
> So perhaps just nx842_exec(), for "execute a request", and then you can
> have nx842_exec_icswx() and nx842_exec_vas().
>
> cheers
>
Michael,
Thanks for review,
nx842_powernv_function() was used before, So just renamed similar to this name. But I will make changes in the next version.
Haren
prev parent reply other threads:[~2017-04-05 3:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 16:59 [PATCH 1/5] crypto/nx: Rename nx842_powernv_function as icswx function Haren Myneni
2017-04-04 11:11 ` Michael Ellerman
2017-04-05 3:32 ` Haren Myneni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58E46535.5080108@linux.vnet.ibm.com \
--to=haren@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=ddstreet@ieee.org \
--cc=hbabu@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=suka@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).