* Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms [not found] <20170317100602.2837-8-horia.geanta@nxp.com> @ 2017-04-04 5:03 ` Michael Ellerman 2017-04-04 13:28 ` Laurentiu Tudor 0 siblings, 1 reply; 6+ messages in thread From: Michael Ellerman @ 2017-04-04 5:03 UTC (permalink / raw) To: Horia Geantă, Herbert Xu, Scott Wood, Roy Pledge Cc: David S. Miller, linux-crypto, linux-arm-kernel, Dan Douglass, Alexandru Porosanu, Vakul Garg, Cristian Stoica, Claudiu Manoil, linuxppc-dev Horia Geant=C4=83 <horia.geanta@nxp.com> writes: > Add support to submit ablkcipher and authenc algorithms > via the QI backend: > -ablkcipher: > cbc({aes,des,des3_ede}) > ctr(aes), rfc3686(ctr(aes)) > xts(aes) > -authenc: > authenc(hmac(md5),cbc({aes,des,des3_ede})) > authenc(hmac(sha*),cbc({aes,des,des3_ede})) > > caam/qi being a new driver, let's wait some time to settle down without > interfering with existing caam/jr driver. > Accordingly, for now all caam/qi algorithms (caamalg_qi module) are > marked to be of lower priority than caam/jr ones (caamalg module). > > Signed-off-by: Vakul Garg <vakul.garg@nxp.com> > Signed-off-by: Alex Porosanu <alexandru.porosanu@nxp.com> > Signed-off-by: Horia Geant=C4=83 <horia.geanta@nxp.com> > --- > drivers/crypto/caam/Kconfig | 20 +- > drivers/crypto/caam/Makefile | 1 + > drivers/crypto/caam/caamalg.c | 9 +- > drivers/crypto/caam/caamalg_desc.c | 77 +- > drivers/crypto/caam/caamalg_desc.h | 15 +- > drivers/crypto/caam/caamalg_qi.c | 2387 ++++++++++++++++++++++++++++++= ++++++ > drivers/crypto/caam/sg_sw_qm.h | 108 ++ > 7 files changed, 2601 insertions(+), 16 deletions(-) > create mode 100644 drivers/crypto/caam/caamalg_qi.c > create mode 100644 drivers/crypto/caam/sg_sw_qm.h This appears to be blowing up my Freescale (NXP) P5020DS board: Unable to handle kernel paging request for data at address 0x00000020 Faulting instruction address: 0xc0000000004393e4 Oops: Kernel access of bad area, sig: 11 [#1] SMP NR_CPUS=3D24=20 CoreNet Generic Modules linked in: CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.11.0-rc3-compiler_gcc-4.6.3-0= 0046-gb189817cf789 #5 task: c0000000f70c0000 task.stack: c0000000f70c8000 NIP: c0000000004393e4 LR: c0000000004aeba0 CTR: c0000000004fa7d8 REGS: c0000000f70cb160 TRAP: 0300 Not tainted (4.11.0-rc3-compiler_gcc= -4.6.3-00046-gb189817cf789) MSR: 0000000080029000 <CE,EE,ME> CR: 24adbe48 XER: 20000000 DEAR: 0000000000000020 ESR: 0000000000000000 SOFTE: 1=20 GPR00: c0000000006feba0 c0000000f70cb3e0 c000000000e60000 000000000000000= 0=20 GPR04: 0000000000000001 0000000000000000 c000000000e0b290 000000000000000= 3=20 GPR08: 0000000000000004 c000000000ea5280 0000000000000004 000000000000000= 4=20 GPR12: 0000000088adbe22 c00000003fff5000 c000000000ba3518 8000080088090fa= 8=20 GPR16: 0000000000001000 c000000000ba3500 c0000000f72c68d8 000000000000000= 4=20 GPR20: c000000000ea5280 c000000000ba34e8 0000000000000020 000000000000000= 4=20 GPR24: c000000000eab7c0 0000000000000000 c0000000f7fc8818 c000000000eb000= 0=20 GPR28: c0000000f786cc00 c000000000eab780 fffffffff786cc00 c000000000eab7c= 0=20 NIP [c0000000004393e4] .gen_pool_alloc+0x0/0xc LR [c0000000004aeba0] .qman_alloc_cgrid_range+0x24/0x54 Call Trace: [c0000000f70cb3e0] [c000000000504054] .platform_device_register_full+0x12= c/0x150 (unreliable) [c0000000f70cb460] [c0000000006feba0] .caam_qi_init+0x158/0x63c [c0000000f70cb5f0] [c0000000006fc64c] .caam_probe+0x8b8/0x1830 [c0000000f70cb740] [c000000000503288] .platform_drv_probe+0x60/0xac [c0000000f70cb7c0] [c000000000501194] .driver_probe_device+0x248/0x344 [c0000000f70cb870] [c0000000005013b4] .__driver_attach+0x124/0x128 [c0000000f70cb900] [c0000000004fed90] .bus_for_each_dev+0x80/0xcc [c0000000f70cb9a0] [c000000000500858] .driver_attach+0x24/0x38 [c0000000f70cba10] [c00000000050043c] .bus_add_driver+0x14c/0x29c [c0000000f70cbab0] [c000000000501d64] .driver_register+0x8c/0x154 [c0000000f70cbb30] [c000000000503000] .__platform_driver_register+0x48/0x= 5c [c0000000f70cbba0] [c000000000c7f798] .caam_driver_init+0x1c/0x30 [c0000000f70cbc10] [c000000000001904] .do_one_initcall+0x60/0x1a8 [c0000000f70cbcf0] [c000000000c35f30] .kernel_init_freeable+0x248/0x334 [c0000000f70cbdb0] [c0000000000020fc] .kernel_init+0x1c/0xf20 [c0000000f70cbe30] [c0000000000009bc] .ret_from_kernel_thread+0x58/0x9c Instruction dump: eb61ffd8 eb81ffe0 eba1ffe8 ebc1fff0 ebe1fff8 4e800020 38600000 4bffffb0=20 7ce53b78 4bffff0c 7f67db78 4bffff24 <e8a30020> e8c30028 4bfffd30 fbe1fff8= =20 ---[ end trace 9f61087068991b02 ]--- home:linux-next(4)(I)> git bisect log ... git bisect bad b189817cf7894e03fd3700acd923221d3007259e # first bad commit: [b189817cf7894e03fd3700acd923221d3007259e] crypto: caam= /qi - add ablkcipher and authenc algorithms The oops is saying gen_pool_alloc() was called with a NULL pointer, so it seems qm_cgralloc is NULL: static int qman_alloc_range(struct gen_pool *p, u32 *result, u32 cnt) { unsigned long addr; addr =3D gen_pool_alloc(p, cnt); ... int qman_alloc_cgrid_range(u32 *result, u32 count) { return qman_alloc_range(qm_cgralloc, result, count); } I didn't pull the thread any further than that. cheers ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms 2017-04-04 5:03 ` [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms Michael Ellerman @ 2017-04-04 13:28 ` Laurentiu Tudor 2017-04-05 10:06 ` Michael Ellerman 0 siblings, 1 reply; 6+ messages in thread From: Laurentiu Tudor @ 2017-04-04 13:28 UTC (permalink / raw) To: Michael Ellerman, Horia Geantă, Herbert Xu, Scott Wood, Roy Pledge Cc: Claudiu Manoil, Cristian Stoica, Dan Douglass, linux-arm-kernel@lists.infradead.org, Vakul Garg, linuxppc-dev@lists.ozlabs.org, David S. Miller, Alexandru Porosanu, linux-crypto@vger.kernel.org SGkgTWljaGFlbCwNCg0KSnVzdCBhIGNvdXBsZSBvZiBiYXNpYyB0aGluZ3MgdG8gY2hlY2s6DQog IC0gd2FzIHRoZSBkdGIgdXBkYXRlZCB0byB0aGUgbmV3ZXN0Pw0KICAtIGlzIHRoZSBxbWFuIG5v ZGUgcHJlc2VudD8gVGhpcyBzaG91bGQgYmUgZWFzaWx5IHZpc2libGUgaW4gDQovcHJvYy9kZXZp Y2UtdHJlZS9zb2NAZmZlMDAwMDAwL3FtYW5AMzE4MDAwLg0KDQotLS0NCkJlc3QgUmVnYXJkcywg TGF1cmVudGl1DQoNCk9uIDA0LzA0LzIwMTcgMDg6MDMgQU0sIE1pY2hhZWwgRWxsZXJtYW4gd3Jv dGU6DQo+IEhvcmlhIEdlYW50xIMgPGhvcmlhLmdlYW50YUBueHAuY29tPiB3cml0ZXM6DQo+DQo+ PiBBZGQgc3VwcG9ydCB0byBzdWJtaXQgYWJsa2NpcGhlciBhbmQgYXV0aGVuYyBhbGdvcml0aG1z DQo+PiB2aWEgdGhlIFFJIGJhY2tlbmQ6DQo+PiAtYWJsa2NpcGhlcjoNCj4+IGNiYyh7YWVzLGRl cyxkZXMzX2VkZX0pDQo+PiBjdHIoYWVzKSwgcmZjMzY4NihjdHIoYWVzKSkNCj4+IHh0cyhhZXMp DQo+PiAtYXV0aGVuYzoNCj4+IGF1dGhlbmMoaG1hYyhtZDUpLGNiYyh7YWVzLGRlcyxkZXMzX2Vk ZX0pKQ0KPj4gYXV0aGVuYyhobWFjKHNoYSopLGNiYyh7YWVzLGRlcyxkZXMzX2VkZX0pKQ0KPj4N Cj4+IGNhYW0vcWkgYmVpbmcgYSBuZXcgZHJpdmVyLCBsZXQncyB3YWl0IHNvbWUgdGltZSB0byBz ZXR0bGUgZG93biB3aXRob3V0DQo+PiBpbnRlcmZlcmluZyB3aXRoIGV4aXN0aW5nIGNhYW0vanIg ZHJpdmVyLg0KPj4gQWNjb3JkaW5nbHksIGZvciBub3cgYWxsIGNhYW0vcWkgYWxnb3JpdGhtcyAo Y2FhbWFsZ19xaSBtb2R1bGUpIGFyZQ0KPj4gbWFya2VkIHRvIGJlIG9mIGxvd2VyIHByaW9yaXR5 IHRoYW4gY2FhbS9qciBvbmVzIChjYWFtYWxnIG1vZHVsZSkuDQo+Pg0KPj4gU2lnbmVkLW9mZi1i eTogVmFrdWwgR2FyZyA8dmFrdWwuZ2FyZ0BueHAuY29tPg0KPj4gU2lnbmVkLW9mZi1ieTogQWxl eCBQb3Jvc2FudSA8YWxleGFuZHJ1LnBvcm9zYW51QG54cC5jb20+DQo+PiBTaWduZWQtb2ZmLWJ5 OiBIb3JpYSBHZWFudMSDIDxob3JpYS5nZWFudGFAbnhwLmNvbT4NCj4+IC0tLQ0KPj4gICBkcml2 ZXJzL2NyeXB0by9jYWFtL0tjb25maWcgICAgICAgIHwgICAyMCArLQ0KPj4gICBkcml2ZXJzL2Ny eXB0by9jYWFtL01ha2VmaWxlICAgICAgIHwgICAgMSArDQo+PiAgIGRyaXZlcnMvY3J5cHRvL2Nh YW0vY2FhbWFsZy5jICAgICAgfCAgICA5ICstDQo+PiAgIGRyaXZlcnMvY3J5cHRvL2NhYW0vY2Fh bWFsZ19kZXNjLmMgfCAgIDc3ICstDQo+PiAgIGRyaXZlcnMvY3J5cHRvL2NhYW0vY2FhbWFsZ19k ZXNjLmggfCAgIDE1ICstDQo+PiAgIGRyaXZlcnMvY3J5cHRvL2NhYW0vY2FhbWFsZ19xaS5jICAg fCAyMzg3ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPj4gICBkcml2ZXJz L2NyeXB0by9jYWFtL3NnX3N3X3FtLmggICAgIHwgIDEwOCArKw0KPj4gICA3IGZpbGVzIGNoYW5n ZWQsIDI2MDEgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pDQo+PiAgIGNyZWF0ZSBtb2Rl IDEwMDY0NCBkcml2ZXJzL2NyeXB0by9jYWFtL2NhYW1hbGdfcWkuYw0KPj4gICBjcmVhdGUgbW9k ZSAxMDA2NDQgZHJpdmVycy9jcnlwdG8vY2FhbS9zZ19zd19xbS5oDQo+DQo+DQo+IFRoaXMgYXBw ZWFycyB0byBiZSBibG93aW5nIHVwIG15IEZyZWVzY2FsZSAoTlhQKSBQNTAyMERTIGJvYXJkOg0K Pg0KPiAgICBVbmFibGUgdG8gaGFuZGxlIGtlcm5lbCBwYWdpbmcgcmVxdWVzdCBmb3IgZGF0YSBh dCBhZGRyZXNzIDB4MDAwMDAwMjANCj4gICAgRmF1bHRpbmcgaW5zdHJ1Y3Rpb24gYWRkcmVzczog MHhjMDAwMDAwMDAwNDM5M2U0DQo+ICAgIE9vcHM6IEtlcm5lbCBhY2Nlc3Mgb2YgYmFkIGFyZWEs IHNpZzogMTEgWyMxXQ0KPiAgICBTTVAgTlJfQ1BVUz0yNA0KPiAgICBDb3JlTmV0IEdlbmVyaWMN Cj4gICAgTW9kdWxlcyBsaW5rZWQgaW46DQo+ICAgIENQVTogMCBQSUQ6IDEgQ29tbTogc3dhcHBl ci8wIE5vdCB0YWludGVkIDQuMTEuMC1yYzMtY29tcGlsZXJfZ2NjLTQuNi4zLTAwMDQ2LWdiMTg5 ODE3Y2Y3ODkgIzUNCj4gICAgdGFzazogYzAwMDAwMDBmNzBjMDAwMCB0YXNrLnN0YWNrOiBjMDAw MDAwMGY3MGM4MDAwDQo+ICAgIE5JUDogYzAwMDAwMDAwMDQzOTNlNCBMUjogYzAwMDAwMDAwMDRh ZWJhMCBDVFI6IGMwMDAwMDAwMDA0ZmE3ZDgNCj4gICAgUkVHUzogYzAwMDAwMDBmNzBjYjE2MCBU UkFQOiAwMzAwICAgTm90IHRhaW50ZWQgICg0LjExLjAtcmMzLWNvbXBpbGVyX2djYy00LjYuMy0w MDA0Ni1nYjE4OTgxN2NmNzg5KQ0KPiAgICBNU1I6IDAwMDAwMDAwODAwMjkwMDAgPENFLEVFLE1F Pg0KPiAgICAgIENSOiAyNGFkYmU0OCAgWEVSOiAyMDAwMDAwMA0KPiAgICBERUFSOiAwMDAwMDAw MDAwMDAwMDIwIEVTUjogMDAwMDAwMDAwMDAwMDAwMCBTT0ZURTogMQ0KPiAgICBHUFIwMDogYzAw MDAwMDAwMDZmZWJhMCBjMDAwMDAwMGY3MGNiM2UwIGMwMDAwMDAwMDBlNjAwMDAgMDAwMDAwMDAw MDAwMDAwMA0KPiAgICBHUFIwNDogMDAwMDAwMDAwMDAwMDAwMSAwMDAwMDAwMDAwMDAwMDAwIGMw MDAwMDAwMDBlMGIyOTAgMDAwMDAwMDAwMDAwMDAwMw0KPiAgICBHUFIwODogMDAwMDAwMDAwMDAw MDAwNCBjMDAwMDAwMDAwZWE1MjgwIDAwMDAwMDAwMDAwMDAwMDQgMDAwMDAwMDAwMDAwMDAwNA0K PiAgICBHUFIxMjogMDAwMDAwMDA4OGFkYmUyMiBjMDAwMDAwMDNmZmY1MDAwIGMwMDAwMDAwMDBi YTM1MTggODAwMDA4MDA4ODA5MGZhOA0KPiAgICBHUFIxNjogMDAwMDAwMDAwMDAwMTAwMCBjMDAw MDAwMDAwYmEzNTAwIGMwMDAwMDAwZjcyYzY4ZDggMDAwMDAwMDAwMDAwMDAwNA0KPiAgICBHUFIy MDogYzAwMDAwMDAwMGVhNTI4MCBjMDAwMDAwMDAwYmEzNGU4IDAwMDAwMDAwMDAwMDAwMjAgMDAw MDAwMDAwMDAwMDAwNA0KPiAgICBHUFIyNDogYzAwMDAwMDAwMGVhYjdjMCAwMDAwMDAwMDAwMDAw MDAwIGMwMDAwMDAwZjdmYzg4MTggYzAwMDAwMDAwMGViMDAwMA0KPiAgICBHUFIyODogYzAwMDAw MDBmNzg2Y2MwMCBjMDAwMDAwMDAwZWFiNzgwIGZmZmZmZmZmZjc4NmNjMDAgYzAwMDAwMDAwMGVh YjdjMA0KPiAgICBOSVAgW2MwMDAwMDAwMDA0MzkzZTRdIC5nZW5fcG9vbF9hbGxvYysweDAvMHhj DQo+ICAgIExSIFtjMDAwMDAwMDAwNGFlYmEwXSAucW1hbl9hbGxvY19jZ3JpZF9yYW5nZSsweDI0 LzB4NTQNCj4gICAgQ2FsbCBUcmFjZToNCj4gICAgW2MwMDAwMDAwZjcwY2IzZTBdIFtjMDAwMDAw MDAwNTA0MDU0XSAucGxhdGZvcm1fZGV2aWNlX3JlZ2lzdGVyX2Z1bGwrMHgxMmMvMHgxNTAgKHVu cmVsaWFibGUpDQo+ICAgIFtjMDAwMDAwMGY3MGNiNDYwXSBbYzAwMDAwMDAwMDZmZWJhMF0gLmNh YW1fcWlfaW5pdCsweDE1OC8weDYzYw0KPiAgICBbYzAwMDAwMDBmNzBjYjVmMF0gW2MwMDAwMDAw MDA2ZmM2NGNdIC5jYWFtX3Byb2JlKzB4OGI4LzB4MTgzMA0KPiAgICBbYzAwMDAwMDBmNzBjYjc0 MF0gW2MwMDAwMDAwMDA1MDMyODhdIC5wbGF0Zm9ybV9kcnZfcHJvYmUrMHg2MC8weGFjDQo+ICAg IFtjMDAwMDAwMGY3MGNiN2MwXSBbYzAwMDAwMDAwMDUwMTE5NF0gLmRyaXZlcl9wcm9iZV9kZXZp Y2UrMHgyNDgvMHgzNDQNCj4gICAgW2MwMDAwMDAwZjcwY2I4NzBdIFtjMDAwMDAwMDAwNTAxM2I0 XSAuX19kcml2ZXJfYXR0YWNoKzB4MTI0LzB4MTI4DQo+ICAgIFtjMDAwMDAwMGY3MGNiOTAwXSBb YzAwMDAwMDAwMDRmZWQ5MF0gLmJ1c19mb3JfZWFjaF9kZXYrMHg4MC8weGNjDQo+ICAgIFtjMDAw MDAwMGY3MGNiOWEwXSBbYzAwMDAwMDAwMDUwMDg1OF0gLmRyaXZlcl9hdHRhY2grMHgyNC8weDM4 DQo+ICAgIFtjMDAwMDAwMGY3MGNiYTEwXSBbYzAwMDAwMDAwMDUwMDQzY10gLmJ1c19hZGRfZHJp dmVyKzB4MTRjLzB4MjljDQo+ICAgIFtjMDAwMDAwMGY3MGNiYWIwXSBbYzAwMDAwMDAwMDUwMWQ2 NF0gLmRyaXZlcl9yZWdpc3RlcisweDhjLzB4MTU0DQo+ICAgIFtjMDAwMDAwMGY3MGNiYjMwXSBb YzAwMDAwMDAwMDUwMzAwMF0gLl9fcGxhdGZvcm1fZHJpdmVyX3JlZ2lzdGVyKzB4NDgvMHg1Yw0K PiAgICBbYzAwMDAwMDBmNzBjYmJhMF0gW2MwMDAwMDAwMDBjN2Y3OThdIC5jYWFtX2RyaXZlcl9p bml0KzB4MWMvMHgzMA0KPiAgICBbYzAwMDAwMDBmNzBjYmMxMF0gW2MwMDAwMDAwMDAwMDE5MDRd IC5kb19vbmVfaW5pdGNhbGwrMHg2MC8weDFhOA0KPiAgICBbYzAwMDAwMDBmNzBjYmNmMF0gW2Mw MDAwMDAwMDBjMzVmMzBdIC5rZXJuZWxfaW5pdF9mcmVlYWJsZSsweDI0OC8weDMzNA0KPiAgICBb YzAwMDAwMDBmNzBjYmRiMF0gW2MwMDAwMDAwMDAwMDIwZmNdIC5rZXJuZWxfaW5pdCsweDFjLzB4 ZjIwDQo+ICAgIFtjMDAwMDAwMGY3MGNiZTMwXSBbYzAwMDAwMDAwMDAwMDliY10gLnJldF9mcm9t X2tlcm5lbF90aHJlYWQrMHg1OC8weDljDQo+ICAgIEluc3RydWN0aW9uIGR1bXA6DQo+ICAgIGVi NjFmZmQ4IGViODFmZmUwIGViYTFmZmU4IGViYzFmZmYwIGViZTFmZmY4IDRlODAwMDIwIDM4NjAw MDAwIDRiZmZmZmIwDQo+ICAgIDdjZTUzYjc4IDRiZmZmZjBjIDdmNjdkYjc4IDRiZmZmZjI0IDxl OGEzMDAyMD4gZThjMzAwMjggNGJmZmZkMzAgZmJlMWZmZjgNCj4gICAgLS0tWyBlbmQgdHJhY2Ug OWY2MTA4NzA2ODk5MWIwMiBdLS0tDQo+DQo+DQo+IGhvbWU6bGludXgtbmV4dCg0KShJKT4gZ2l0 IGJpc2VjdCBsb2cNCj4gLi4uDQo+IGdpdCBiaXNlY3QgYmFkIGIxODk4MTdjZjc4OTRlMDNmZDM3 MDBhY2Q5MjMyMjFkMzAwNzI1OWUNCj4gIyBmaXJzdCBiYWQgY29tbWl0OiBbYjE4OTgxN2NmNzg5 NGUwM2ZkMzcwMGFjZDkyMzIyMWQzMDA3MjU5ZV0gY3J5cHRvOiBjYWFtL3FpIC0gYWRkIGFibGtj aXBoZXIgYW5kIGF1dGhlbmMgYWxnb3JpdGhtcw0KPg0KPg0KPiBUaGUgb29wcyBpcyBzYXlpbmcg Z2VuX3Bvb2xfYWxsb2MoKSB3YXMgY2FsbGVkIHdpdGggYSBOVUxMIHBvaW50ZXIsIHNvDQo+IGl0 IHNlZW1zIHFtX2NncmFsbG9jIGlzIE5VTEw6DQo+DQo+IHN0YXRpYyBpbnQgcW1hbl9hbGxvY19y YW5nZShzdHJ1Y3QgZ2VuX3Bvb2wgKnAsIHUzMiAqcmVzdWx0LCB1MzIgY250KQ0KPiB7DQo+IAl1 bnNpZ25lZCBsb25nIGFkZHI7DQo+DQo+IAlhZGRyID0gZ2VuX3Bvb2xfYWxsb2MocCwgY250KTsN Cj4gCS4uLg0KPg0KPiBpbnQgcW1hbl9hbGxvY19jZ3JpZF9yYW5nZSh1MzIgKnJlc3VsdCwgdTMy IGNvdW50KQ0KPiB7DQo+IAlyZXR1cm4gcW1hbl9hbGxvY19yYW5nZShxbV9jZ3JhbGxvYywgcmVz dWx0LCBjb3VudCk7DQo+IH0NCj4NCj4NCj4gSSBkaWRuJ3QgcHVsbCB0aGUgdGhyZWFkIGFueSBm dXJ0aGVyIHRoYW4gdGhhdC4NCj4NCj4gY2hlZXJzDQo+ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms 2017-04-04 13:28 ` Laurentiu Tudor @ 2017-04-05 10:06 ` Michael Ellerman 2017-04-05 11:49 ` Laurentiu Tudor 0 siblings, 1 reply; 6+ messages in thread From: Michael Ellerman @ 2017-04-05 10:06 UTC (permalink / raw) To: Laurentiu Tudor, Horia Geantă, Herbert Xu, Scott Wood, Roy Pledge Cc: Claudiu Manoil, Cristian Stoica, Dan Douglass, linux-arm-kernel@lists.infradead.org, Vakul Garg, linuxppc-dev@lists.ozlabs.org, David S. Miller, Alexandru Porosanu, linux-crypto@vger.kernel.org Laurentiu Tudor <laurentiu.tudor@nxp.com> writes: > Hi Michael, > > Just a couple of basic things to check: > - was the dtb updated to the newest? Possibly not, it's an automated build/boot, I'll have to check what it does with the dtb. > - is the qman node present? This should be easily visible in > /proc/device-tree/soc@ffe000000/qman@318000. No it's not there. That's running linux-next with: CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI=n Does that mean I didn't update the device tree? cheers ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms 2017-04-05 10:06 ` Michael Ellerman @ 2017-04-05 11:49 ` Laurentiu Tudor 2017-04-07 13:21 ` Michael Ellerman 0 siblings, 1 reply; 6+ messages in thread From: Laurentiu Tudor @ 2017-04-05 11:49 UTC (permalink / raw) To: Michael Ellerman, Horia Geantă, Herbert Xu, Scott Wood, Roy Pledge Cc: Claudiu Manoil, Cristian Stoica, Dan Douglass, linux-arm-kernel@lists.infradead.org, Vakul Garg, linuxppc-dev@lists.ozlabs.org, David S. Miller, Alexandru Porosanu, linux-crypto@vger.kernel.org DQoNCk9uIDA0LzA1LzIwMTcgMDE6MDYgUE0sIE1pY2hhZWwgRWxsZXJtYW4gd3JvdGU6DQo+IExh dXJlbnRpdSBUdWRvciA8bGF1cmVudGl1LnR1ZG9yQG54cC5jb20+IHdyaXRlczoNCj4NCj4+IEhp IE1pY2hhZWwsDQo+Pg0KPj4gSnVzdCBhIGNvdXBsZSBvZiBiYXNpYyB0aGluZ3MgdG8gY2hlY2s6 DQo+PiAgICAtIHdhcyB0aGUgZHRiIHVwZGF0ZWQgdG8gdGhlIG5ld2VzdD8NCj4NCj4gUG9zc2li bHkgbm90LCBpdCdzIGFuIGF1dG9tYXRlZCBidWlsZC9ib290LCBJJ2xsIGhhdmUgdG8gY2hlY2sg d2hhdCBpdA0KPiBkb2VzIHdpdGggdGhlIGR0Yi4NCj4NCj4+ICAgIC0gaXMgdGhlIHFtYW4gbm9k ZSBwcmVzZW50PyBUaGlzIHNob3VsZCBiZSBlYXNpbHkgdmlzaWJsZSBpbg0KPj4gL3Byb2MvZGV2 aWNlLXRyZWUvc29jQGZmZTAwMDAwMC9xbWFuQDMxODAwMC4NCj4NCj4gTm8gaXQncyBub3QgdGhl cmUuDQo+DQo+IFRoYXQncyBydW5uaW5nIGxpbnV4LW5leHQgd2l0aDoNCj4NCj4gQ09ORklHX0NS WVBUT19ERVZfRlNMX0NBQU1fQ1JZUFRPX0FQSV9RST1uDQo+DQo+DQo+IERvZXMgdGhhdCBtZWFu IEkgZGlkbid0IHVwZGF0ZSB0aGUgZGV2aWNlIHRyZWU/DQo+DQoNCkkgdGhpbmsgc28uIEFsc28s IEkganVzdCBjaGVja2VkIHRoYXQgdGhlIG5vZGUgaXMgYWN0dWFsbHkgdGhlcmUgYnkgDQpjb21w aWxpbmcgcDUwMjBkcy5kdHMgYW5kIHRoZW4gZGVjb21waWxpbmcgdGhlIGR0Yi4NCg0KLS0tDQpC ZXN0IFJlZ2FyZHMsIExhdXJlbnRpdQ== ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms 2017-04-05 11:49 ` Laurentiu Tudor @ 2017-04-07 13:21 ` Michael Ellerman 2017-04-07 14:00 ` Laurentiu Tudor 0 siblings, 1 reply; 6+ messages in thread From: Michael Ellerman @ 2017-04-07 13:21 UTC (permalink / raw) To: Laurentiu Tudor, Horia Geantă, Herbert Xu, Scott Wood, Roy Pledge Cc: Claudiu Manoil, Cristian Stoica, Dan Douglass, linux-arm-kernel@lists.infradead.org, Vakul Garg, linuxppc-dev@lists.ozlabs.org, David S. Miller, Alexandru Porosanu, linux-crypto@vger.kernel.org Laurentiu Tudor <laurentiu.tudor@nxp.com> writes: > On 04/05/2017 01:06 PM, Michael Ellerman wrote: >> Laurentiu Tudor <laurentiu.tudor@nxp.com> writes: >> >>> Hi Michael, >>> >>> Just a couple of basic things to check: >>> - was the dtb updated to the newest? >> >> Possibly not, it's an automated build/boot, I'll have to check what it >> does with the dtb. >> >>> - is the qman node present? This should be easily visible in >>> /proc/device-tree/soc@ffe000000/qman@318000. >> >> No it's not there. >> >> That's running linux-next with: >> >> CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI=n >> >> >> Does that mean I didn't update the device tree? > > I think so. Also, I just checked that the node is actually there by > compiling p5020ds.dts and then decompiling the dtb. OK, I'll make sure I update the DTB. It will still be good if the code was a bit more robust about the qman being missing. cheers ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms 2017-04-07 13:21 ` Michael Ellerman @ 2017-04-07 14:00 ` Laurentiu Tudor 0 siblings, 0 replies; 6+ messages in thread From: Laurentiu Tudor @ 2017-04-07 14:00 UTC (permalink / raw) To: Michael Ellerman, Horia Geantă, Herbert Xu, Scott Wood, Roy Pledge Cc: Claudiu Manoil, Cristian Stoica, Dan Douglass, linux-arm-kernel@lists.infradead.org, Vakul Garg, linuxppc-dev@lists.ozlabs.org, David S. Miller, Alexandru Porosanu, linux-crypto@vger.kernel.org -----Original Message----- From: Michael Ellerman [mailto:mpe@ellerman.id.au]=20 Sent: Friday, April 07, 2017 4:22 PM To: Laurentiu Tudor <laurentiu.tudor@nxp.com>; Horia Geant=E3 <horia.geanta= @nxp.com>; Herbert Xu <herbert@gondor.apana.org.au>; Scott Wood <oss@buserr= or.net>; Roy Pledge <roy.pledge@nxp.com> Cc: Claudiu Manoil <claudiu.manoil@nxp.com>; Cristian Stoica <cristian.stoi= ca@nxp.com>; Dan Douglass <dan.douglass@nxp.com>; linux-arm-kernel@lists.in= fradead.org; Vakul Garg <vakul.garg@nxp.com>; linuxppc-dev@lists.ozlabs.org= ; David S. Miller <davem@davemloft.net>; Alexandru Porosanu <alexandru.poro= sanu@nxp.com>; linux-crypto@vger.kernel.org Subject: Re: [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms Importance: High Laurentiu Tudor <laurentiu.tudor@nxp.com> writes: > On 04/05/2017 01:06 PM, Michael Ellerman wrote: >> Laurentiu Tudor <laurentiu.tudor@nxp.com> writes: >> >>> Hi Michael, >>> >>> Just a couple of basic things to check: >>> - was the dtb updated to the newest? >> >> Possibly not, it's an automated build/boot, I'll have to check what=20 >> it does with the dtb. >> >>> - is the qman node present? This should be easily visible in=20 >>> /proc/device-tree/soc@ffe000000/qman@318000. >> >> No it's not there. >> >> That's running linux-next with: >> >> CONFIG_CRYPTO_DEV_FSL_CAAM_CRYPTO_API_QI=3Dn >> >> >> Does that mean I didn't update the device tree? > > I think so. Also, I just checked that the node is actually there by=20 > compiling p5020ds.dts and then decompiling the dtb. > OK, I'll make sure I update the DTB. >=20 > It will still be good if the code was a bit more robust about the qman be= ing missing. Totally agree. We should handle this error condition. --- Thanks & Best Regards, Laurentiu ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-07 14:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170317100602.2837-8-horia.geanta@nxp.com>
2017-04-04 5:03 ` [7/7] crypto: caam/qi - add ablkcipher and authenc algorithms Michael Ellerman
2017-04-04 13:28 ` Laurentiu Tudor
2017-04-05 10:06 ` Michael Ellerman
2017-04-05 11:49 ` Laurentiu Tudor
2017-04-07 13:21 ` Michael Ellerman
2017-04-07 14:00 ` Laurentiu Tudor
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).