Re: [PATCH] powerpc/pseries/dlpar: use rtas_get_sensor()

[Laurent Dufour <ldufour@linux.ibm.com>]

Le 04/05/2021 à 04:53, Nathan Lynch a écrit :
> Instead of making bare calls to get-sensor-state, use
> rtas_get_sensor(), which correctly handles busy and extended delay
> statuses.

Reviewed-by: Laurent Dufour <ldufour@linux.ibm.com>

> Fixes: ab519a011caa ("powerpc/pseries: Kernel DLPAR Infrastructure")
> Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
> ---
>   arch/powerpc/platforms/pseries/dlpar.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/pseries/dlpar.c b/arch/powerpc/platforms/pseries/dlpar.c
> index 3ac70790ec7a..b1f01ac0c29e 100644
> --- a/arch/powerpc/platforms/pseries/dlpar.c
> +++ b/arch/powerpc/platforms/pseries/dlpar.c
> @@ -289,8 +289,7 @@ int dlpar_acquire_drc(u32 drc_index)
>   {
>   	int dr_status, rc;
>   
> -	rc = rtas_call(rtas_token("get-sensor-state"), 2, 2, &dr_status,
> -		       DR_ENTITY_SENSE, drc_index);
> +	rc = rtas_get_sensor(DR_ENTITY_SENSE, drc_index, &dr_status);
>   	if (rc || dr_status != DR_ENTITY_UNUSABLE)
>   		return -1;
>   
> @@ -311,8 +310,7 @@ int dlpar_release_drc(u32 drc_index)
>   {
>   	int dr_status, rc;
>   
> -	rc = rtas_call(rtas_token("get-sensor-state"), 2, 2, &dr_status,
> -		       DR_ENTITY_SENSE, drc_index);
> +	rc = rtas_get_sensor(DR_ENTITY_SENSE, drc_index, &dr_status);
>   	if (rc || dr_status != DR_ENTITY_PRESENT)
>   		return -1;
>   
> @@ -333,8 +331,7 @@ int dlpar_unisolate_drc(u32 drc_index)
>   {
>   	int dr_status, rc;
>   
> -	rc = rtas_call(rtas_token("get-sensor-state"), 2, 2, &dr_status,
> -				DR_ENTITY_SENSE, drc_index);
> +	rc = rtas_get_sensor(DR_ENTITY_SENSE, drc_index, &dr_status);
>   	if (rc || dr_status != DR_ENTITY_PRESENT)
>   		return -1;
>   
>