From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
"oss@buserror.net" <oss@buserror.net>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc: allow compiling with GENERIC_MSI_IRQ
Date: Fri, 30 Jun 2017 10:25:42 +0000 [thread overview]
Message-ID: <595626F0.2090700@nxp.com> (raw)
In-Reply-To: <8737ahrdn9.fsf@concordia.ellerman.id.au>
Hi Michael,
On 06/30/2017 01:08 PM, Michael Ellerman wrote:
> Hi Laurentiu,
>
> laurentiu.tudor@nxp.com writes:
>> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
>>
>> This allows building powerpc with the GENERIC_MSI_IRQ Kconfig
>> by enabling the asm-generic msi.h in Kbuild. Without this,
>> there's a compilation error [1] because powerpc, as most arches,
>> doesn't provide an asm/msi.h.
>>
>> [1] In file included from ./include/linux/kvm_host.h:20:0,
>> from ./arch/powerpc/include/asm/kvm_ppc.h:30,
>> from arch/powerpc/kernel/dbell.c:20:
>> ./include/linux/msi.h:195:21: fatal error: asm/msi.h: No such file or di=
rectory
>
> I have >50 configs here with GENERIC_MSI_IRQ=3Dy, so I don't understand
> what's going wrong for you.
>
> Can you tell me more about what you're doing and how it's breaking.
>
Actually i made an error in the commit message, sorry about that. It's=20
GENERIC_MSI_IRQ_DOMAIN that breaks the arch/powerpc build. If this is=20
enabled, the generic header include/linux/msi.h wants an asm/msi.h and=20
we don't have one on powerpc. That's what the patch tries to fix.
Want me to resend with the correct commit message? ... if you're ok with=20
the patch, of course.
---
Thanks & Best Regards, Laurentiu=
prev parent reply other threads:[~2017-06-30 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-30 9:50 [PATCH] powerpc: allow compiling with GENERIC_MSI_IRQ laurentiu.tudor
2017-06-30 10:08 ` Michael Ellerman
2017-06-30 10:25 ` Laurentiu Tudor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=595626F0.2090700@nxp.com \
--to=laurentiu.tudor@nxp.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=oss@buserror.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).