From: Gustavo Romero <gromero@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, Gustavo Romero <gromero@linux.ibm.com>
Subject: Re: [PATCH 3/3] powerpc/tm: Add tm-poison test
Date: Wed, 4 Sep 2019 01:59:50 -0300 [thread overview]
Message-ID: <59912aa2-336b-2e44-822f-e400d0decb9f@linux.vnet.ibm.com> (raw)
In-Reply-To: <87k1apr49n.fsf@mpe.ellerman.id.au>
Hi Michael,
On 09/03/2019 08:46 AM, Michael Ellerman wrote:
> Michael Neuling <mikey@neuling.org> writes:
>> From: Gustavo Romero <gromero@linux.ibm.com>
>>
>> Add TM selftest to check if FP or VEC register values from one process
>> can leak into another process when both run on the same CPU.
>>
>> This tests for CVE-2019-15030 and CVE-2019-15031.
>>
>> Signed-off-by: Gustavo Romero <gromero@linux.ibm.com>
>> Signed-off-by: Michael Neuling <mikey@neuling.org>
>> ---
>> tools/testing/selftests/powerpc/tm/.gitignore | 1 +
>> tools/testing/selftests/powerpc/tm/Makefile | 2 +-
>> .../testing/selftests/powerpc/tm/tm-poison.c | 180 ++++++++++++++++++
>> 3 files changed, 182 insertions(+), 1 deletion(-)
>> create mode 100644 tools/testing/selftests/powerpc/tm/tm-poison.c
>
> This doesn't build on 64-bit big endian:
>
> tm-poison.c: In function 'tm_poison_test':
> tm-poison.c:118:10: error: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=]
> printf("Unknown value %#lx leaked into f31!\n", unknown);
> ^
> tm-poison.c:166:10: error: format '%lx' expects argument of type 'long unsigned int', but argument 2 has type 'uint64_t {aka long long unsigned int}' [-Werror=format=]
> printf("Unknown value %#lx leaked into vr31!\n", unknown);
> ^
Sorry. I sent a v2 addressing it. Now I tested the fix against Travis CI.
Thank you.
Cheers,
Gustavo
next prev parent reply other threads:[~2019-09-04 5:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 4:47 [PATCH 1/3] powerpc/tm: Fix FP/VMX unavailable exceptions inside a transaction Michael Neuling
2019-09-03 4:47 ` [PATCH 2/3] powerpc/tm: Fix restoring FP/VMX facility incorrectly on interrupts Michael Neuling
2019-09-03 4:47 ` [PATCH 3/3] powerpc/tm: Add tm-poison test Michael Neuling
2019-09-03 11:46 ` Michael Ellerman
2019-09-04 4:59 ` Gustavo Romero [this message]
2019-09-04 4:55 ` [PATCH v2 1/3] powerpc/tm: Fix FP/VMX unavailable exceptions inside a transaction gromero
2019-09-04 4:55 ` [PATCH v2 2/3] powerpc/tm: Fix restoring FP/VMX facility incorrectly on interrupts gromero
2019-09-05 12:05 ` Michael Ellerman
2019-09-04 4:55 ` [PATCH v2 3/3] powerpc/tm: Add tm-poison test gromero
2019-09-25 11:05 ` Michael Ellerman
2019-09-05 12:05 ` [PATCH v2 1/3] powerpc/tm: Fix FP/VMX unavailable exceptions inside a transaction Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59912aa2-336b-2e44-822f-e400d0decb9f@linux.vnet.ibm.com \
--to=gromero@linux.vnet.ibm.com \
--cc=gromero@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).