From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-x243.google.com (mail-pf0-x243.google.com [IPv6:2607:f8b0:400e:c00::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3yJ2ZT58lFzDqGr for ; Fri, 20 Oct 2017 08:46:57 +1100 (AEDT) Received: by mail-pf0-x243.google.com with SMTP id b6so7906968pfh.7 for ; Thu, 19 Oct 2017 14:46:57 -0700 (PDT) Subject: Re: [PATCH v2 5/5] of/fdt: only store the device node basename in full_name To: Moritz Fischer , Pantelis Antoniou References: <20170821151651.25096-1-robh@kernel.org> <20170821151651.25096-6-robh@kernel.org> <59E69786.2030406@gmail.com> <1508341985.25643.12.camel@hp800z> <4393AFA4-620F-4C21-995D-A9806DAE1990@konsulko.com> <20171019200615.GA10743@tyrael.ni.corp.natinst.com> Cc: Rob Herring , Alan Tull , "devicetree@vger.kernel.org" , Michael Ellerman , linuxppc-dev , linux-kernel , Benjamin Herrenschmidt , Paul Mackerras , David Laight , linux-fpga@vger.kernel.org From: Frank Rowand Message-ID: <59E91D4D.8000200@gmail.com> Date: Thu, 19 Oct 2017 14:46:53 -0700 MIME-Version: 1.0 In-Reply-To: <20171019200615.GA10743@tyrael.ni.corp.natinst.com> Content-Type: text/plain; charset=utf-8 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 10/19/17 13:06, Moritz Fischer wrote: < snip > > We also have plenty of code that is just not aware of overlays, and > assumes certain parts of the tree to stay static. I would state that somewhat differently. :-) There is very little code that is aware of overlays, and most code assumes the device tree does not change after early boot. This is one of the areas where the creation of overlays needs to be done with care. > I ran into that issue when I tried to add thermal zones via an overlay, > I've been investigating how to fix the thermal framework to work with > overlays since then and have some partially working code. > Currently the thermal framework parses the thermal-zones node at boot, > and assumes this stays static. This breaks with overlays. > > I agree we eventually need to fix the parts that break when we use > overlays.