From: Kumar Gala <galak@kernel.crashing.org>
To: David Updegraff <dave@cray.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: reset mpc83xx plaform.
Date: Wed, 22 Mar 2006 12:15:19 -0600 [thread overview]
Message-ID: <5C3A5367-69A2-4681-B781-74414C9FCDBA@kernel.crashing.org> (raw)
In-Reply-To: <dvs108$8d8$1@sea.gmane.org>
On Mar 22, 2006, at 11:20 AM, David Updegraff wrote:
> Hi.
>
> I think there's some typo-errs. in arch/powerpc/platforms/83xx/misc.c.
> In my case, these result in board lockup at 'reboot' instead of reset.
>
> By my reading of the PDF, it needs to be patched thusly.
Yeah, this fix should be in what Paul just sent to linus for 2.6.17.
I guess I could push to get it into 2.6.16.x if desired.
- kumar
> diff --git a/arch/powerpc/platforms/83xx/misc.c b/arch/powerpc/
> platforms/83xx/misc.c
> index 0eb3d99..d918d45 100644
> --- a/arch/powerpc/platforms/83xx/misc.c
> +++ b/arch/powerpc/platforms/83xx/misc.c
> @@ -24,6 +24,7 @@ void mpc83xx_restart(char *cmd)
> #define RST_OFFSET 0x00000900
> #define RST_PROT_REG 0x00000018
> #define RST_CTRL_REG 0x0000001c
> +#define RST_ENBL_REG 0x00000020
> __be32 __iomem *reg;
>
> /* map reset register space */
> @@ -34,8 +35,12 @@ void mpc83xx_restart(char *cmd)
> /* enable software reset "RSTE" */
> out_be32(reg + (RST_PROT_REG >> 2), 0x52535445);
>
> + /* wait for reset to get enabled */
> + while ((in_be32 (reg + (RST_ENBL_REG >> 2)) & 1) == 0 )
> + ;
> +
> /* set software hard reset */
> - out_be32(reg + (RST_CTRL_REG >> 2), 0x52535445);
> + out_be32(reg + (RST_CTRL_REG >> 2), 3);
> for (;;) ;
> }
>
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
prev parent reply other threads:[~2006-03-22 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-22 17:20 reset mpc83xx plaform David Updegraff
2006-03-22 18:15 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C3A5367-69A2-4681-B781-74414C9FCDBA@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=dave@cray.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox