From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-ia64 <linux-ia64@vger.kernel.org>,
Sebastian Ott <sebott@linux.ibm.com>,
linux-doc <linux-doc@vger.kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Paul Mackerras <paulus@samba.org>,
"H . Peter Anvin" <hpa@zytor.com>,
linux-s390 <linux-s390@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
Joerg Roedel <joro@8bytes.org>, x86 <x86@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Fenghua Yu <fenghua.yu@intel.com>,
Will Deacon <will.deacon@arm.com>,
John Garry <john.garry@huawei.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Borislav Petkov <bp@alien8.de>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
Tony Luck <tony.luck@intel.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
iommu <iommu@lists.linux-foundation.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v4 0/6] normalize IOMMU dma mode boot options
Date: Mon, 8 Apr 2019 17:51:56 +0800 [thread overview]
Message-ID: <5CAB19BC.2040804@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1904080829490.1840@nanos.tec.linutronix.de>
On 2019/4/8 14:32, Thomas Gleixner wrote:
> On Mon, 8 Apr 2019, Leizhen (ThunderTown) wrote:
>>>
>>> This will break systems using boot options as now, and I think
>>> this is unacceptable. If you want to do so, just introduce iommu.dma_mode
>>> on top of those iommu boot options with dma mode boot options unchanged,
>>> and iommu.dma_mode is for all archs but compatible with them.
>>
>> I just changed the boot options name, but keep the function no change. I added
>> all related maintainers/supporters in the "to=" list, maybe we can disuss this.
>
> Changing the name _IS_ the problem. Think about unattended updates.
>
>> Should I add some "obsoleted" warnings for old options and keep them for a while?
>
> No, just keep the old options around for backwards compatibilty sake. We
> just do not add new arch specific options in the future. New options need
> to use the generic iommu.dma_mode name space.
OK, thanks for your advise.
>
> Thanks,
>
> tglx
>
> .
>
--
Thanks!
BestRegards
prev parent reply other threads:[~2019-04-08 9:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-07 12:41 [PATCH v4 0/6] normalize IOMMU dma mode boot options Zhen Lei
2019-04-07 12:41 ` [PATCH v4 1/6] iommu: use iommu.dma_mode to replace iommu.passthrough and iommu.strict Zhen Lei
2019-04-07 12:41 ` [PATCH v4 2/6] iommu: keep dma mode build options consistent with cmdline options Zhen Lei
2019-04-07 12:41 ` [PATCH v4 3/6] iommu: add iommu_default_dma_mode_get() helper Zhen Lei
2019-04-07 12:41 ` [PATCH v4 4/6] s390/pci: use common boot option iommu.dma_mode Zhen Lei
2019-04-07 12:41 ` [PATCH v4 5/6] powernv/iommu: " Zhen Lei
2019-04-07 12:41 ` [PATCH v4 6/6] x86/iommu: " Zhen Lei
2019-04-08 1:14 ` [PATCH v4 0/6] normalize IOMMU dma mode boot options Hanjun Guo
2019-04-08 3:16 ` Leizhen (ThunderTown)
2019-04-08 6:32 ` Thomas Gleixner
2019-04-08 9:51 ` Leizhen (ThunderTown) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CAB19BC.2040804@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=guohanjun@huawei.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe.brucker@arm.com \
--cc=john.garry@huawei.com \
--cc=joro@8bytes.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=robin.murphy@arm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).