From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: linux-ia64 <linux-ia64@vger.kernel.org>,
Sebastian Ott <sebott@linux.ibm.com>,
linux-doc <linux-doc@vger.kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Paul Mackerras <paulus@samba.org>,
"H . Peter Anvin" <hpa@zytor.com>,
linux-s390 <linux-s390@vger.kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Jean-Philippe Brucker <jean-philippe.brucker@arm.com>,
x86 <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Will Deacon <will.deacon@arm.com>,
John Garry <john.garry@huawei.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
Gerald Schaefer <gerald.schaefer@de.ibm.com>,
Tony Luck <tony.luck@intel.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
iommu <iommu@lists.linux-foundation.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH v5 1/6] iommu: add generic boot option iommu.dma_mode
Date: Tue, 23 Apr 2019 10:45:37 +0800 [thread overview]
Message-ID: <5CBE7C51.8070002@huawei.com> (raw)
In-Reply-To: <20190412111649.GK4518@8bytes.org>
On 2019/4/12 19:16, Joerg Roedel wrote:
> On Tue, Apr 09, 2019 at 08:53:03PM +0800, Zhen Lei wrote:
>> +static int __init iommu_dma_mode_setup(char *str)
>> +{
>> + if (!str)
>> + goto fail;
>> +
>> + if (!strncmp(str, "passthrough", 11))
>> + iommu_default_dma_mode = IOMMU_DMA_MODE_PASSTHROUGH;
>> + else if (!strncmp(str, "lazy", 4))
>> + iommu_default_dma_mode = IOMMU_DMA_MODE_LAZY;
>> + else if (!strncmp(str, "strict", 6))
>> + iommu_default_dma_mode = IOMMU_DMA_MODE_STRICT;
>> + else
>> + goto fail;
>> +
>> + pr_info("Force dma mode to be %d\n", iommu_default_dma_mode);
>
> Printing a number is not very desriptive or helpful to the user. Please
> print the name of the mode instead.
OK, thanks. I have given up adding iommu.dma_mode boot option according
to Robin and Will's suggestion. So these codes will be removed in v6.
>
>
> Regards,
>
> Joerg
>
> .
>
--
Thanks!
BestRegards
next prev parent reply other threads:[~2019-04-23 2:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 12:53 [PATCH v5 0/6] add generic boot option for IOMMU dma mode Zhen Lei
2019-04-09 12:53 ` [PATCH v5 1/6] iommu: add generic boot option iommu.dma_mode Zhen Lei
2019-04-12 10:26 ` John Garry
2019-04-12 13:11 ` Robin Murphy
2019-04-16 15:21 ` Will Deacon
2019-04-17 2:36 ` Leizhen (ThunderTown)
2019-04-12 11:16 ` Joerg Roedel
2019-04-23 2:45 ` Leizhen (ThunderTown) [this message]
2019-04-09 12:53 ` [PATCH v5 2/6] iommu: add build options corresponding to iommu.dma_mode Zhen Lei
2019-04-09 12:53 ` [PATCH v5 3/6] iommu: add iommu_default_dma_mode_get/set() helper Zhen Lei
2019-04-09 12:53 ` [PATCH v5 4/6] s390/pci: add support for generic boot option iommu.dma_mode Zhen Lei
2019-04-10 11:46 ` Sebastian Ott
2019-04-09 12:53 ` [PATCH v5 5/6] powernv/iommu: " Zhen Lei
2019-04-09 12:53 ` [PATCH v5 6/6] x86/iommu: " Zhen Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5CBE7C51.8070002@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dwmw2@infradead.org \
--cc=fenghua.yu@intel.com \
--cc=gerald.schaefer@de.ibm.com \
--cc=guohanjun@huawei.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe.brucker@arm.com \
--cc=john.garry@huawei.com \
--cc=joro@8bytes.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=robin.murphy@arm.com \
--cc=schwidefsky@de.ibm.com \
--cc=sebott@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).