From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 4FAACDE438 for ; Tue, 16 Oct 2007 00:02:49 +1000 (EST) In-Reply-To: References: <20071014044041.23438.14070.stgit@trillian.cg.shawcable.net> <20071014044154.23438.58701.stgit@trillian.cg.shawcable.net> <751956FC-6B75-416C-A62A-67915652EA51@kernel.crashing.org> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <5D5FEAFA-AFB9-4F8D-941E-11686E8992F4@kernel.crashing.org> From: Kumar Gala Subject: Re: [PATCH v2 2/7] rheap: Changes config mechanism Date: Mon, 15 Oct 2007 09:03:17 -0500 To: "Grant Likely" Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, domen.puncer@telargo.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Oct 15, 2007, at 8:55 AM, Grant Likely wrote: > On 10/15/07, Kumar Gala wrote: >> >> On Oct 13, 2007, at 11:41 PM, Grant Likely wrote: >> >>> From: Sylvain Munaut >>> >>> Instead of having in the makefile all the option that >>> requires rheap, we define a configuration symbol >>> and when needed we make sure it's selected. >>> >>> Signed-off-by: Sylvain Munaut >>> Signed-off-by: Grant Likely >>> --- >>> >>> + >>> +config PPC_LIB_RHEAP >> >> we should really have help for this option. > > This is a non-user-selectable option; none of the other > non-user-selectable options have help text. I don't see why we can't let users select it (saying that differently, we should let users have this ability) > I can add a comment; want to give me some text to squirt in there? grab something out of the comment at the top of lib/rheap.c - k