From: Kumar Gala <galak@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@ozlabs.org, Jon Loeliger <jdl@jdl.com>,
devicetree-discuss@ozlabs.org
Subject: Re: [PATCH] libfdt: Add support for using aliases in fdt_path_offset()
Date: Thu, 14 Aug 2008 07:02:54 -0500 [thread overview]
Message-ID: <5DCA3107-7574-4E1F-9160-B2257BFE3F81@kernel.crashing.org> (raw)
In-Reply-To: <20080814041557.GE18344@yookeroo.seuss>
On Aug 13, 2008, at 11:15 PM, David Gibson wrote:
> On Wed, Aug 13, 2008 at 10:52:26PM -0500, Kumar Gala wrote:
>> If the path doesn't start with '/' check to see if it matches some
>> alias
>> under "/aliases" and substitute the matching alias value in the path
>> and retry the lookup.
>
> Kumar, this is broken. If you match an alias you only follow the path
> one level down from there. i.e. you will correctly resolve
> 'somealias' and 'somealias/foo', but not 'somealias/foo/bar'.
I'm not clear on what cases you are suggesting fail.
- k
prev parent reply other threads:[~2008-08-14 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 3:52 [PATCH] libfdt: Add support for using aliases in fdt_path_offset() Kumar Gala
2008-08-14 4:15 ` David Gibson
2008-08-14 12:02 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DCA3107-7574-4E1F-9160-B2257BFE3F81@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=david@gibson.dropbear.id.au \
--cc=devicetree-discuss@ozlabs.org \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox