From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id 5D65FDDE9A for ; Wed, 25 Jul 2007 01:33:20 +1000 (EST) In-Reply-To: <18085.59414.38125.30777@cargo.ozlabs.ibm.com> References: <11852238122538-git-send-email-galak@kernel.crashing.org> <1185223813693-git-send-email-galak@kernel.crashing.org> <11852238151983-git-send-email-galak@kernel.crashing.org> <11852238161546-git-send-email-galak@kernel.crashing.org> <1185223818821-git-send-email-galak@kernel.crashing.org> <11852238193371-git-send-email-galak@kernel.crashing.org> <1185223821183-git-send-email-galak@kernel.crashing.org> <11852238233066-git-send-email-galak@kernel.crashing.org> <11852238241475-git-send-email-galak@kernel.crashing.org> <11852238253550-git-send-email-galak@kernel.crashing.org> <11852238271141-git-send-email-galak@kernel.crashing.org> <11852238283648-git-send-email-galak@kernel.crashing.org> <1185223830411-git-send-email-galak@kernel.crashing.org> <11852238322319-git-send-email-galak@kernel.crashing.org> <11852238333649-git-send-email-galak@kernel.crashing.org> <11852238353292-git-send-email-galak@kernel.crashing.org> <11852238362041-git-send-email-galak@kernel.crashing.! org> <11852238383453-git-send-email-galak@kernel.crashing.org> <11852238392809-git-send-email-galak@kernel.crashing.org> <11852238411823-git-send-email-galak@kernel.crashing.org> <11852238421611-git-send-email-galak@kernel.crashing.org> <11852238432011-git-send-email-galak@kernel.crashing.org> <18085.59414.38125.30777@cargo.ozlabs.ibm.com> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <5DCD5E82-1122-426E-8FF4-DF1D1A67EB04@kernel.crashing.org> From: Kumar Gala Subject: Re: [PATCH 21/25] [POWERPC] 85xxCDS: Delay 8259 cascade hookup. Date: Tue, 24 Jul 2007 10:34:04 -0500 To: Paul Mackerras Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Jul 24, 2007, at 6:52 AM, Paul Mackerras wrote: > Kumar Gala writes: > >> From: Randy Vinson > >> +device_initcall(mpc85xx_cds_8259_attach); > > I don't see any platform test in mpc85xx_cds_8259_attach to make sure > it only does its stuff on suitable platforms. Looks like it needs > one. I've added a is_machine(mpc85xx_cds) into the patch in my tree to handle this. - k