From: Kumar Gala <kumar.gala@freescale.com>
To: "Tom Rini" <trini@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: building ppc_htab?
Date: Thu, 17 Mar 2005 23:12:17 -0600 [thread overview]
Message-ID: <5aa169978e1eb58d1b61f211646a873b@freescale.com> (raw)
In-Reply-To: <20050317215852.GJ8345@smtp.west.cox.net>
> > Crap :(
> >
> > > #ifdef CONFIG_PPC32
> > >=A0=A0=A0=A0=A0=A0=A0=A0 {
> > >=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 extern struct =
file_operations ppc_htab_operations;
> > >=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 entry =3D =
create_proc_entry("ppc_htab",=20
> S_IRUGO|S_IWUSR,
> > > NULL);
> > >=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (entry)
> > >=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0 entry->proc_fops =3D &ppc_htab_operations;
> > >=A0=A0=A0=A0=A0=A0=A0=A0 }
> > > #endif
> > >
> > > Are you suggesting this should live elsewhere?=A0 I'm not that=20
> familiar
> > > with proc code.
> >
> > Yes, it should live in ppc_htab.c.=A0 See the CONFIG_SYSCTL stuff=20
> already
> > in ppc_htab.c for l2crvec.
>
> Der, that's not the same thing!=A0 I still swear there's a way to do =
this
> w/o messing w/ fs/proc/proc_misc.c, but I don't recall a good =
example.
Will, for now I will add a conditional on CONFIG_PPC_STD_MMU. We can=20
move this out once we figure out how to do it outside of=20
fs/proc/proc_misc.c.
- kumar
prev parent reply other threads:[~2005-03-18 5:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-16 6:57 building ppc_htab? Kumar Gala
2005-03-16 17:12 ` Dan Malek
2005-03-16 22:11 ` Tom Rini
2005-03-17 17:34 ` Kumar Gala
2005-03-17 17:41 ` Tom Rini
2005-03-17 21:58 ` Tom Rini
2005-03-18 5:12 ` Kumar Gala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5aa169978e1eb58d1b61f211646a873b@freescale.com \
--to=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).