LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christophe Leroy (CS GROUP)" <chleroy@kernel.org>
To: Link Mauve <linkmauve@linkmauve.fr>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: "Madhavan Srinivasan" <maddy@linux.ibm.com>,
	techflashYT <officialTechflashYT@gmail.com>,
	"Ash Logan" <ash@heyquark.com>,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Nicholas Piggin" <npiggin@gmail.com>
Subject: Re: [PATCH 0/2] powerpc/sstep: Fix compilation on 32-bit PowerPC
Date: Thu, 30 Jul 2026 07:51:40 +0200	[thread overview]
Message-ID: <5c140099-4448-4091-979a-6f6fe7d92ce8@kernel.org> (raw)
In-Reply-To: <20260729204958.755143-1-linkmauve@linkmauve.fr>



Le 29/07/2026 à 22:49, Link Mauve a écrit :
> Two local variables were only set but never read on 32-bit PowerPC,
> which causes an error during compilation.

Are those errors new ? This series and the one from yesterday on ppc64, 
I have the feeling that the code is not new. Has anything changed in the 
building flags or does this pops up with recent versions of GCC ? If it 
is the case it is worth saying it in the commit messages in order to 
clarify the reason for the fix.

> 
> This series first makes the 64-bit guards consistent by converting all
> uses of CONFIG_PPC64 to use __powerpc64__ instead, and then guard the
> two variables rc and suffix behind __powerpc64__ checks.
> 
> Link Mauve (2):
>    powerpc/sstep: Consistently use one define to check arch bit width
>    powerpc/sstep: Don’t define variables we won’t be using
> 
>   arch/powerpc/lib/sstep.c | 26 ++++++++++++++++----------
>   1 file changed, 16 insertions(+), 10 deletions(-)
> 
> 
> base-commit: 78bc8af4affb9a732504eb22eeac7d1e50883853



  parent reply	other threads:[~2026-07-30  5:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-29 20:49 [PATCH 0/2] powerpc/sstep: Fix compilation on 32-bit PowerPC Link Mauve
2026-07-29 20:49 ` [PATCH 1/2] powerpc/sstep: Consistently use one define to check arch bit width Link Mauve
2026-07-30  6:02   ` LEROY Christophe
2026-07-29 20:49 ` [PATCH 2/2] powerpc/sstep: Don’t define variables we won’t be using Link Mauve
2026-07-30  6:24   ` Christophe Leroy (CS GROUP)
2026-07-30  6:39     ` Link Mauve
2026-07-30  5:51 ` Christophe Leroy (CS GROUP) [this message]
2026-07-30  6:04   ` [PATCH 0/2] powerpc/sstep: Fix compilation on 32-bit PowerPC Link Mauve

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5c140099-4448-4091-979a-6f6fe7d92ce8@kernel.org \
    --to=chleroy@kernel.org \
    --cc=ash@heyquark.com \
    --cc=j.neuschaefer@gmx.net \
    --cc=linkmauve@linkmauve.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=officialTechflashYT@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox