From: Paolo Abeni <pabeni@redhat.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Douglas Miller <dougmill@linux.ibm.com>,
Dany Madden <drt@linux.ibm.com>,
Sukadev Bhattiprolu <sukadev@linux.ibm.com>,
Thomas Falcon <tlfalcon@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Ishizaki Kou <kou.ishizaki@toshiba.co.jp>,
Geoff Levand <geoff@infradead.org>
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: ethernet: Prepare cleanup of powerpc's asm/prom.h
Date: Tue, 19 Apr 2022 09:22:21 +0200 [thread overview]
Message-ID: <5cd406e8f8e77f6025d77ec1e0e46296694002d4.camel@redhat.com> (raw)
In-Reply-To: <f995b36fc3f2a3793038300388f06d1c3dd7e69a.1650011798.git.christophe.leroy@csgroup.eu>
Hello,
Sorry for the late reply.
On Fri, 2022-04-15 at 10:39 +0200, Christophe Leroy wrote:
> powerpc's asm/prom.h brings some headers that it doesn't
> need itself.
It's probably my fault, but I really can't parse the above. Could you
please re-phrase?
>
> In order to clean it up in a further step, first clean all
> files that include asm/prom.h
>
> Some files don't need asm/prom.h at all. For those ones,
> just remove inclusion of asm/prom.h
>
> Some files don't need any of the items provided by asm/prom.h,
> but need some of the headers included by asm/prom.h. For those
> ones, add the needed headers that are brought by asm/prom.h at
> the moment, then remove asm/prom.h
Do you mean a follow-up patch is needed to drop the asm/prom.h include
from such files, even if that include could be dropped now without any
fourther change?
If so, I suggest v3 should additionally drop the asm/prom.h include
where possible.
Thanks!
Paolo
prev parent reply other threads:[~2022-04-19 7:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 8:39 [PATCH net-next v2] net: ethernet: Prepare cleanup of powerpc's asm/prom.h Christophe Leroy
2022-04-19 7:22 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cd406e8f8e77f6025d77ec1e0e46296694002d4.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=dougmill@linux.ibm.com \
--cc=drt@linux.ibm.com \
--cc=geoff@infradead.org \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=sukadev@linux.ibm.com \
--cc=tlfalcon@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).