From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5930EA4E33 for ; Mon, 2 Mar 2026 16:07:31 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4fPkNL0lq0z3blr; Tue, 03 Mar 2026 03:07:30 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip="2600:3c04:e001:324:0:1991:8:25" ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772467650; cv=none; b=MsySFEaj+xlGL0BaqA14ZQYkGBQbi+RVaBPFv3WFsWZSBpYlz+m676v7FigsvSoba2VZwNpH+CM/6q+N0Ry0pWRMVScQYblO1bRirwlhuTbCF5G+JNdMWv6MSUV3YTEC+hmmYT92lpVytszV9BoimFHeI79Dh0jU+d+579a+N+n6+y6czBDN6gteept9pIWGPqhPNwhOLQbb2ZyZgD2vakz/v1ZnSChL6BtQhJBZA7j3OxXnMa5txl71MrJ9CqBsMFtXD1FwRiezfuZvjES0M+T4NYNSZ9+tG3KGVwviKmvJci8UyPa50f5HlptTWWqc6A5VyXvzjraAHG8lXx4gPw== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1772467650; c=relaxed/relaxed; bh=LKcwJQ+aQkiImKNptCJqjwgkBdF0BmXTAZbJZzaoNO4=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=Gjf4EQXKojK2cXXQDJWmUPEhH9sOAHnPO+feH+Vdd2eY8VDj83vbXPBfoydeBVeg7ZuJaxLv0YznQOot3Lo9vO05YIBsR7SSTKR2Jl16S8oLByC0aI1DSsThtx/3RfPR3A+ry89bgqLKyiYfIHWBxtJiNA3s6N6DdKZHHgYQw+l607ayMdFmTPHXdwIyyTCoW1bcplMUiKyF0EfQEvfr52dONX1oFUyaJbN14KQtC7wf+8q/W8UzO02U/FXKwVdrS8KufxbMYUlCIMxoQxD6EWEALr/nkvK5jVuDtZ70Hy0G46Iw+SUglCcMdYN3QD3Wn/pkhxOd5MVPvwlL1D0DSg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=IMLp9T97; dkim-atps=neutral; spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=chleroy@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=IMLp9T97; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org; envelope-from=chleroy@kernel.org; receiver=lists.ozlabs.org) Received: from tor.source.kernel.org (tor.source.kernel.org [IPv6:2600:3c04:e001:324:0:1991:8:25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4fPkNK2xchz3bkL for ; Tue, 03 Mar 2026 03:07:29 +1100 (AEDT) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 4321B60008; Mon, 2 Mar 2026 16:07:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88AD7C19423; Mon, 2 Mar 2026 16:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772467645; bh=Q4f5IphZs1HK0nenixYFPe8rEaCz8xjgoIeWN6zDZUo=; h=Date:Subject:To:References:From:In-Reply-To:From; b=IMLp9T97Z1WGqMa4vKl8aLMG1SCE+RTETM4LF9HiMKYx4UrsyfNc9AmTDAGMeQxpx atWX3a+51jxWTnQfRmsvdiTbUN5rkz4n69cFBN9Vaugs7LwCYmh6fDHvK5BH95218S WjTE7/IyxVl5IgiZ9xplzxjGM5hkgVvNAXL1Z1enx+z/+fXCcGFwXMTuwRFFzTqiGk S9kzt7FFHlwJc14uSgPaUHzirBOUCLO109ioqQTYkZsBASo9Vte2pZwBVGSWpTn/BA OyyNKXo2fT5eBtBhIb63i0iitx6BOkgqZj36M2Gp4ZCV608BRToV1uBjtWBe/i8M7c IezwEcB5TWUBA== Message-ID: <5cef9283-c718-4832-9ef6-71f1722cb8e1@kernel.org> Date: Mon, 2 Mar 2026 17:07:14 +0100 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 next 5/5] signal: Use scoped_user_access() instead of __put/get_user() To: david.laight.linux@gmail.com, Alexander Viro , Andre Almeida , Andrew Cooper , Christian Borntraeger , Christian Brauner , Christophe Leroy , Darren Hart , Davidlohr Bueso , Heiko Carstens , Jan Kara , Julia Lawall , Linus Torvalds , linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, LKML , Madhavan Srinivasan , Mathieu Desnoyers , Michael Ellerman , Nicholas Piggin , Nicolas Palix , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Russell King , Sven Schnelle , Thomas Gleixner , x86@kernel.org, Kees Cook , akpm@linux-foundation.org References: <20260302132755.1475451-1-david.laight.linux@gmail.com> <20260302132755.1475451-6-david.laight.linux@gmail.com> Content-Language: fr-FR From: "Christophe Leroy (CS GROUP)" In-Reply-To: <20260302132755.1475451-6-david.laight.linux@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 02/03/2026 à 14:27, david.laight.linux@gmail.com a écrit : > From: David Laight > > Mechanically change the access_ok() and __get/put_user() to use > scoped_user_read/write_access() and unsafe_get/put_user(). > > This generates better code with fewer STAC/CLAC pairs. > > It also ensures that access_ok() is called near the user accesses. > I failed to find the one for __save_altstack(). On arm64 it's done in get_sigframe() it seems. > > Looking at the change, perhaps there should be aliases: > #define scoped_put_user unsafe_put_user > #define scoped_get_user unsafe_get_user Might be confusing to have two macros doing exactly the same thing. And the churn might be unnecessary on some code that already widely use unsafe_xxx macros and that we want to convert to scoped user access, like for instance arch/powerpc/kernel/signal_32.c Christophe