From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Geoff Levand <geoff@infradead.org>, linuxppc-dev@lists.ozlabs.org
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Jens Axboe <axboe@kernel.dk>, Jim Paris <jim@jtan.com>,
Michael Ellerman <mpe@ellerman.id.au>
Subject: Re: block/ps3vram: Check return of ps3vram_cache_init
Date: Tue, 8 Aug 2017 14:46:13 +0200 [thread overview]
Message-ID: <5df6ae90-8b7d-8418-b2ee-15dbebfa3e95@users.sourceforge.net> (raw)
In-Reply-To: <f1d16f5ac3eb170493ca7835a7c39c1b4675a81f.1502135910.git.geoff@infradead.org>
> @@ -741,7 +741,11 @@ static int ps3vram_probe(struct ps3_system_bus_device *dev)
> goto out_unmap_reports;
> }
>
> - ps3vram_cache_init(dev);
> + error = ps3vram_cache_init(dev);
> + if (error < 0) {
> + goto out_unmap_reports;
> + }
> +
> ps3vram_proc_init(dev);
>
> queue = blk_alloc_queue(GFP_KERNEL);
I pointed a few development concerns out.
https://patchwork.ozlabs.org/patch/798575/
Will the commit subject “block/ps3vram: Check return value of ps3vram_cache_init()”
be more appropriate?
Regards,
Markus
next prev parent reply other threads:[~2017-08-08 12:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 20:09 [PATCH 0/3] Minor updates for PS3 Geoff Levand
2017-08-07 20:09 ` [PATCH 2/3] block/ps3vram: Check return of ps3vram_cache_init Geoff Levand
2017-08-08 12:46 ` SF Markus Elfring [this message]
2017-08-18 12:51 ` [2/3] " Michael Ellerman
2017-08-07 20:09 ` [PATCH 3/3] powerpc/ps3: Refresh ps3_defconfig Geoff Levand
2017-08-07 20:09 ` [PATCH 1/3] block/ps3vram: Delete an error message for a failed memory allocation in ps3vram_cache_init() Geoff Levand
2017-08-18 12:51 ` [1/3] " Michael Ellerman
2017-08-08 10:16 ` [PATCH 0/3] Minor updates for PS3 Michael Ellerman
2017-08-08 14:25 ` Jens Axboe
2017-08-09 6:16 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5df6ae90-8b7d-8418-b2ee-15dbebfa3e95@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=geoff@infradead.org \
--cc=jim@jtan.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).