linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Sourabh Jain <sourabhjain@linux.ibm.com>
To: "David Hildenbrand (Red Hat)" <david@kernel.org>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Cc: Donet Tom <donettom@linux.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: powerpc/e500: WARNING: at mm/hugetlb.c:4755 hugetlb_add_hstate
Date: Fri, 7 Nov 2025 18:05:42 +0530	[thread overview]
Message-ID: <5e4bc56e-f0ca-45b3-a7c8-114e7009dfd8@linux.ibm.com> (raw)
In-Reply-To: <b875435f-6a69-4989-bc21-4093c2ce6331@kernel.org>


On 07/11/25 14:32, David Hildenbrand (Red Hat) wrote:
> On 07.11.25 09:00, Sourabh Jain wrote:
>>
>>
>> On 06/11/25 20:32, David Hildenbrand (Red Hat) wrote:
>>>>> Yes, we discussed that in [1].
>>>>>
>>>>> We'll have to set ARCH_HAS_GIGANTIC_PAGE on ppc and increase
>>>>> MAX_FOLIO_ORDER, because apparently, there might be ppc configs that
>>>>> have even larger hugetlb sizes than PUDs.
>>>>>
>>>>> @Cristophe, I was under the impression that you would send a fix. Do
>>>>> you
>>>>> want me to prepare something and send it out?
>>>>
>>>> Indeed I would have liked to better understand the implications of all
>>>> this, but I didn't have the time.
>>>
>>> Indeed, too me longer than it should to understand and make up my mind
>>> as well.
>>>
>>>>
>>>> By the way, you would describe the fix better than me so yes if you 
>>>> can
>>>> prepare and send a fix please do.
>>>
>>> I just crafted the following. I yet have to test it more, some early
>>> feedback+testing would be appreciated!
>>>
>>>  From 274928854644c49c92515f8675c090dba15a0db6 Mon Sep 17 00:00:00 2001
>>> From: "David Hildenbrand (Red Hat)" <david@kernel.org>
>>> Date: Thu, 6 Nov 2025 11:31:45 +0100
>>> Subject: [PATCH] mm: fix MAX_FOLIO_ORDER on some ppc64 configs with
>>> hugetlb
>>
>> b4 did not detect this patch, and manually copying the patch text 
>> from this
>> reply also did not apply cleanly on upstream master and linuxppc
>> master/next.
>
> I have it on a branch here:
>
> https://github.com/davidhildenbrand/linux/commit/274928854644c49c92515f8675c090dba15a0db6 
>
>
> https://github.com/davidhildenbrand/linux.git max_folio_order
>

The above patch resolves the issue reported in this thread.

Thanks for the fix David.

Thanks,
Sourabh Jain


  reply	other threads:[~2025-11-07 12:36 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29  5:49 powerpc/e500: WARNING: at mm/hugetlb.c:4755 hugetlb_add_hstate Sourabh Jain
2025-10-29  8:25 ` David Hildenbrand
2025-11-05 11:32   ` Christophe Leroy
2025-11-06 15:02     ` David Hildenbrand (Red Hat)
2025-11-06 16:19       ` Christophe Leroy
2025-11-07 14:37         ` Ritesh Harjani
2025-11-07 16:11           ` Christophe Leroy
2025-11-10 10:10           ` David Hildenbrand (Red Hat)
2025-11-10 10:33             ` Christophe Leroy
2025-11-10 11:04               ` David Hildenbrand (Red Hat)
2025-11-10 11:27         ` David Hildenbrand (Red Hat)
2025-11-10 18:31           ` Christophe Leroy
2025-11-11  8:29             ` David Hildenbrand (Red Hat)
2025-11-11 11:21               ` David Hildenbrand (Red Hat)
2025-11-11 11:42                 ` Christophe Leroy
2025-11-11 12:20                   ` David Hildenbrand (Red Hat)
2025-11-12 10:41             ` Ritesh Harjani
2025-11-07  8:00       ` Sourabh Jain
2025-11-07  9:02         ` David Hildenbrand (Red Hat)
2025-11-07 12:35           ` Sourabh Jain [this message]
2025-11-07 14:18             ` David Hildenbrand (Red Hat)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e4bc56e-f0ca-45b3-a7c8-114e7009dfd8@linux.ibm.com \
    --to=sourabhjain@linux.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=david@kernel.org \
    --cc=donettom@linux.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.ibm.com \
    --cc=ritesh.list@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).