From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40m4cz68FPzF1Rl for ; Wed, 16 May 2018 16:42:59 +1000 (AEST) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w4G6eRiZ080848 for ; Wed, 16 May 2018 02:42:56 -0400 Received: from e06smtp15.uk.ibm.com (e06smtp15.uk.ibm.com [195.75.94.111]) by mx0b-001b2d01.pphosted.com with ESMTP id 2j0dy2utpk-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 16 May 2018 02:42:56 -0400 Received: from localhost by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 16 May 2018 07:42:54 +0100 Subject: Re: [PATCH v10 23/25] mm: add speculative page fault vmstats To: Ganesh Mahendran Cc: Andrew Morton , Michal Hocko , Peter Zijlstra , kirill@shutemov.name, ak@linux.intel.com, dave@stgolabs.net, jack@suse.cz, Matthew Wilcox , benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org, Thomas Gleixner , Ingo Molnar , hpa@zytor.com, Will Deacon , Sergey Senozhatsky , Andrea Arcangeli , Alexei Starovoitov , kemi.wang@intel.com, Sergey Senozhatsky , Daniel Jordan , David Rientjes , Jerome Glisse , linux-kernel , Linux-MM , haren@linux.vnet.ibm.com, khandual@linux.vnet.ibm.com, npiggin@gmail.com, Balbir Singh , Paul McKenney , Tim Chen , linuxppc-dev@lists.ozlabs.org, x86@kernel.org References: <1523975611-15978-1-git-send-email-ldufour@linux.vnet.ibm.com> <1523975611-15978-24-git-send-email-ldufour@linux.vnet.ibm.com> From: Laurent Dufour Date: Wed, 16 May 2018 08:42:43 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Message-Id: <5e98d70e-5eb0-32d0-f370-f0946fd17b49@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 16/05/2018 04:50, Ganesh Mahendran wrote: > 2018-04-17 22:33 GMT+08:00 Laurent Dufour : >> Add speculative_pgfault vmstat counter to count successful speculative page >> fault handling. >> >> Also fixing a minor typo in include/linux/vm_event_item.h. >> >> Signed-off-by: Laurent Dufour >> --- >> include/linux/vm_event_item.h | 3 +++ >> mm/memory.c | 1 + >> mm/vmstat.c | 5 ++++- >> 3 files changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/include/linux/vm_event_item.h b/include/linux/vm_event_item.h >> index 5c7f010676a7..a240acc09684 100644 >> --- a/include/linux/vm_event_item.h >> +++ b/include/linux/vm_event_item.h >> @@ -111,6 +111,9 @@ enum vm_event_item { PGPGIN, PGPGOUT, PSWPIN, PSWPOUT, >> SWAP_RA, >> SWAP_RA_HIT, >> #endif >> +#ifdef CONFIG_SPECULATIVE_PAGE_FAULT >> + SPECULATIVE_PGFAULT, >> +#endif >> NR_VM_EVENT_ITEMS >> }; >> >> diff --git a/mm/memory.c b/mm/memory.c >> index 425f07e0bf38..1cd5bc000643 100644 >> --- a/mm/memory.c >> +++ b/mm/memory.c >> @@ -4508,6 +4508,7 @@ int __handle_speculative_fault(struct mm_struct *mm, unsigned long address, >> * If there is no need to retry, don't return the vma to the caller. >> */ >> if (ret != VM_FAULT_RETRY) { >> + count_vm_event(SPECULATIVE_PGFAULT); >> put_vma(vmf.vma); >> *vma = NULL; >> } >> diff --git a/mm/vmstat.c b/mm/vmstat.c >> index 536332e988b8..c6b49bfa8139 100644 >> --- a/mm/vmstat.c >> +++ b/mm/vmstat.c >> @@ -1289,7 +1289,10 @@ const char * const vmstat_text[] = { >> "swap_ra", >> "swap_ra_hit", >> #endif >> -#endif /* CONFIG_VM_EVENTS_COUNTERS */ >> +#ifdef CONFIG_SPECULATIVE_PAGE_FAULT >> + "speculative_pgfault" > > "speculative_pgfault", > will be better. :) Sure ! Thanks. > >> +#endif >> +#endif /* CONFIG_VM_EVENT_COUNTERS */ >> }; >> #endif /* CONFIG_PROC_FS || CONFIG_SYSFS || CONFIG_NUMA */ >> >> -- >> 2.7.4 >> >