From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3xNwcN0JgrzDqG5 for ; Fri, 4 Aug 2017 15:35:16 +1000 (AEST) Received: from ozlabs.org (ozlabs.org [IPv6:2401:3900:2:1::2]) by bilbo.ozlabs.org (Postfix) with ESMTP id 3xNwcM6ktwz8vyj for ; Fri, 4 Aug 2017 15:35:15 +1000 (AEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3xNwcM34FKz9s7C for ; Fri, 4 Aug 2017 15:35:15 +1000 (AEST) Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v745TKCU033414 for ; Fri, 4 Aug 2017 01:35:13 -0400 Received: from e23smtp07.au.ibm.com (e23smtp07.au.ibm.com [202.81.31.140]) by mx0a-001b2d01.pphosted.com with ESMTP id 2c4hus3c20-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 04 Aug 2017 01:35:13 -0400 Received: from localhost by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 4 Aug 2017 15:35:11 +1000 Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v745Z9gL21627002 for ; Fri, 4 Aug 2017 15:35:09 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v745Z8xO008097 for ; Fri, 4 Aug 2017 15:35:08 +1000 Subject: Re: [PATCH 1/4] powerpc/prom: avoid endian conversions for linux, memory-limit node To: benh@au1.ibm.com, linuxppc-dev Cc: sjitindarsingh@gmail.com, stable@vger.kernel.org, Paul Mackerras , ben@codiert.org References: <150175227508.9806.17545018023658850483.stgit@hbathini.in.ibm.com> <1501810658.2664.60.camel@kernel.crashing.org> <1501811252.2664.66.camel@au1.ibm.com> From: Hari Bathini Date: Fri, 4 Aug 2017 11:05:05 +0530 MIME-Version: 1.0 In-Reply-To: <1501811252.2664.66.camel@au1.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: <5ed46248-95fa-df97-92eb-c05eead306d0@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Friday 04 August 2017 07:17 AM, Benjamin Herrenschmidt wrote: > On Fri, 2017-08-04 at 11:37 +1000, Benjamin Herrenschmidt wrote: >> On Thu, 2017-08-03 at 14:54 +0530, Hari Bathini wrote: >>> As linux,memory-limit node is set and also later used by the kernel, >>> avoid endian conversions for this property. >>> >>> Fixes: 493adffcb43f ("powerpc: Make prom_init.c endian safe") >>> Cc: stable@vger.kernel.org # 3.12+ >>> Cc: Anton Blanchard >>> Cc: Benjamin Herrenschmidt >>> Signed-off-by: Hari Bathini >>> --- >>> arch/powerpc/kernel/prom_init.c | 3 +-- >>> 1 file changed, 1 insertion(+), 2 deletions(-) >>> >>> diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c >>> index 613f79f..723df83 100644 >>> --- a/arch/powerpc/kernel/prom_init.c >>> +++ b/arch/powerpc/kernel/prom_init.c >>> @@ -3180,9 +3180,8 @@ unsigned long __init prom_init(unsigned long r3, unsigned long r4, >>> * Fill in some infos for use by the kernel later on >>> */ >>> if (prom_memory_limit) { >>> - __be64 val = cpu_to_be64(prom_memory_limit); >>> prom_setprop(prom.chosen, "/chosen", "linux,memory-limit", >>> - &val, sizeof(val)); >>> + &prom_memory_limit, sizeof(prom_memory_limit)); >>> } >>> #ifdef CONFIG_PPC64 >>> if (prom_iommu_off) >> NACK. The device-tree is big endian by convention > Also that probably breaks kexec. > Actually, mem= is broken for a while as endian conversion is done for linux,memory-limit node in prom_init.c but not in prom.c. Will post fix with endian conversion done in prom.c.. Thanks Hari