From: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
benh@kernel.crashing.org, paulus@samba.org,
maurosr@linux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/powernv: Enable reset_devices parameter to issue a PHB reset
Date: Fri, 13 Oct 2017 10:02:58 -0300 [thread overview]
Message-ID: <5f9d3902-5982-7ea6-951f-10f2b90d00b4@linux.vnet.ibm.com> (raw)
In-Reply-To: <87fuantpdk.fsf@concordia.ellerman.id.au>
On 10/13/2017 05:37 AM, Michael Ellerman wrote:
>
> I really dislike this.
>
> You're basically saying the kernel can't work out how to get a device
> working, so let's leave it up to the user.
Oh, it was never my intention to say such blasphemy :)
It meant to be just a debug option to help the users, specifically the
ones debugging drivers, to try using a hammer to recover bad devices! To
this issue that I mentioned as an example, the fix specifically goes in
the FW of the adapter.
Anyway, since you really dislike it, let's drop it, no big deal!
Cheers,
Guilherme
>
> The driver should be fixed to detect that the device is not responding
> and request a reset.
>
> cheers
>
next prev parent reply other threads:[~2017-10-13 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-12 22:21 [PATCH] powerpc/powernv: Enable reset_devices parameter to issue a PHB reset Guilherme G. Piccoli
2017-10-13 8:37 ` Michael Ellerman
2017-10-13 13:02 ` Guilherme G. Piccoli [this message]
2017-10-14 9:13 ` Benjamin Herrenschmidt
2017-10-15 21:51 ` Guilherme G. Piccoli
2017-10-25 15:30 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f9d3902-5982-7ea6-951f-10f2b90d00b4@linux.vnet.ibm.com \
--to=gpiccoli@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maurosr@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).