From: Tirumala Marri <tmarri@apm.com>
To: Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Subject: RE: [PATCH V8 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver
Date: Tue, 25 Jan 2011 14:06:41 -0800 [thread overview]
Message-ID: <5fc573f3ae6c3de2c5bbfe0052a45f5e@mail.gmail.com> (raw)
In-Reply-To: <20110123030150.GA28358@kroah.com>
-----Original Message-----
From: Greg KH [mailto:greg@kroah.com]
Sent: Saturday, January 22, 2011 7:02 PM
To: tmarri@apm.com
Cc: linux-usb@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V8 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver
On Wed, Jan 19, 2011 at 02:57:16PM -0800, tmarri@apm.com wrote:
> From: Tirumala Marri <tmarri@apm.com>
>
> v8:
> 1. Add set_wedge to usb_ep_ops.
>
> v7:
> 1. Fix sparse tool warnings.
> 2. Fix checkpatch errors and warnings.
> 3. Rename USB_OTG config variable to USB_DWC_CONFIG
>
> Tirumala Marri (10):
> USB/ppc4xx: Add Synopsys DWC OTG Register definitions
> USB/ppc4xx: Add Synopsys DWC OTG driver framework
> USB/ppc4xx: Add Synopsys DWC OTG Core Interface Layer
> USB/ppc4xx: Add Synopsys DWC OTG HCD function
> USB/ppc4xx: Add Synopsys DWC OTG HCD interrupt function
> USB/ppc4xx: Add Synopsys DWC OTG HCD queue function
> USB/ppc4xx: Add Synopsys DWC OTG PCD function
> USB ppc4xx: Add Synopsys DWC OTG PCD interrupt function
> USB/ppc4xx:Synopsys DWC OTG driver enable gadget support
> USB ppc4xx: Add Synopsys DWC OTG driver kernel configuration and
> Makefile
>
> drivers/Makefile | 2 +
> drivers/usb/Kconfig | 3 +-
> drivers/usb/dwc_otg/Kconfig | 96 ++
Why are you creating a new subdirectory here? Shouldn't it be in
drivers/usb/otg/dwc/ instead?
> drivers/usb/dwc_otg/Makefile | 19 +
> drivers/usb/dwc_otg/dwc_otg_apmppc.c | 414 ++++++
> drivers/usb/dwc_otg/dwc_otg_cil.c | 972 ++++++++++++
> drivers/usb/dwc_otg/dwc_otg_cil.h | 1220 +++++++++++++++
> drivers/usb/dwc_otg/dwc_otg_cil_intr.c | 616 ++++++++
> drivers/usb/dwc_otg/dwc_otg_driver.h | 76 +
> drivers/usb/dwc_otg/dwc_otg_hcd.c | 2466
+++++++++++++++++++++++++++++++
> drivers/usb/dwc_otg/dwc_otg_hcd.h | 416 ++++++
> drivers/usb/dwc_otg/dwc_otg_hcd_intr.c | 1477 ++++++++++++++++++
> drivers/usb/dwc_otg/dwc_otg_hcd_queue.c | 696 +++++++++
> drivers/usb/dwc_otg/dwc_otg_param.c | 180 +++
> drivers/usb/dwc_otg/dwc_otg_pcd.c | 1766 ++++++++++++++++++++++
> drivers/usb/dwc_otg/dwc_otg_pcd.h | 139 ++
> drivers/usb/dwc_otg/dwc_otg_pcd_intr.c | 2311
+++++++++++++++++++++++++++++
> drivers/usb/dwc_otg/dwc_otg_regs.h | 1325 +++++++++++++++++
As you are in your own subdir, no need to put "dwc_otg_" at the start of
every file name, right?
Care to make these changes and resend?
[Marri] Sure I will make changes and resend.
-Marri
prev parent reply other threads:[~2011-01-25 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 22:57 [PATCH V8 00/10] Add-Synopsys-DesignWare-HS-USB-OTG-driver tmarri
2011-01-23 3:01 ` Greg KH
2011-01-25 22:06 ` Tirumala Marri [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fc573f3ae6c3de2c5bbfe0052a45f5e@mail.gmail.com \
--to=tmarri@apm.com \
--cc=greg@kroah.com \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).