From: Kumar Gala <kumar.gala@freescale.com>
To: "Sylvain Munaut" <tnt@246tNt.com>
Cc: Asier Llano Palacios <a.llano@usyscom.com>,
ML linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] i2c: Race fix for i2c-mpc.c
Date: Mon, 16 May 2005 10:30:56 -0500 [thread overview]
Message-ID: <5fe12cfac05d60b8af016382594e50db@freescale.com> (raw)
In-Reply-To: <0.20050516_092837.tnt@patchsend.246tNt.com>
Sylvain,
Are you really still using the OCP side of the driver? Do we need a=20
similar fix for the platform driver side?
- kumar
On May 16, 2005, at 1:24 AM, Sylvain Munaut wrote:
> i2c: Race fix for i2c-mpc.c
>
> The problem was that the clock speed and driver data is
> initialized after the i2c adapter was added. This caused
> the i2c bus to start working at a wrong speed. (Mostly
> noticable on the second bus on mpc5200)
>
> With this patch we've tried to keep the i2c adapter
> working perfectly all the time it is included in the system.
> Initialize before added, Remove garbage after deleleted.
>
>
>
> Submitted-by: Asier Llano Palacios
> Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
> ---
> --- linux-2.6/drivers/i2c/busses/i2c-mpc.c=A0=A0=A0=A0=A0 2005-05-16=20=
> 09:08:02.000000000 +0200
> +++ linux-2.6/drivers/i2c/busses/i2c-mpc.c=A0=A0=A0=A0=A0 2005-05-16=20=
> 09:09:51.000000000 +0200
> @@ -333,6 +333,9 @@
> =A0=A0=A0=A0=A0=A0=A0 } else
> =A0=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 i2c->irq =3D 0;
> =A0
> +=A0=A0=A0=A0=A0=A0 mpc_i2c_setclock(i2c);
> +=A0=A0=A0=A0=A0=A0 ocp_set_drvdata(ocp, i2c);
> +
> =A0=A0=A0=A0=A0=A0=A0 i2c->adap =3D mpc_ops;
> =A0=A0=A0=A0=A0=A0=A0 i2c_set_adapdata(&i2c->adap, i2c);
> =A0
> @@ -341,8 +344,6 @@
> =A0=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 goto fail_add;
> =A0=A0=A0=A0=A0=A0=A0 }
> =A0
> -=A0=A0=A0=A0=A0=A0 mpc_i2c_setclock(i2c);
> -=A0=A0=A0=A0=A0=A0 ocp_set_drvdata(ocp, i2c);
> =A0=A0=A0=A0=A0=A0=A0 return result;
> =A0
> =A0=A0=A0=A0=A0=A0 fail_add:
> @@ -358,8 +359,8 @@
> =A0static void __devexit mpc_i2c_remove(struct ocp_device *ocp)
> =A0{
> =A0=A0=A0=A0=A0=A0=A0 struct mpc_i2c *i2c =3D ocp_get_drvdata(ocp);
> -=A0=A0=A0=A0=A0=A0 ocp_set_drvdata(ocp, NULL);
> =A0=A0=A0=A0=A0=A0=A0 i2c_del_adapter(&i2c->adap);
> +=A0=A0=A0=A0=A0=A0 ocp_set_drvdata(ocp, NULL);
> =A0
> =A0=A0=A0=A0=A0=A0=A0 if (ocp->def->irq !=3D OCP_IRQ_NA)
> =A0=A0=A0=A0=A0=A0=A0 =A0=A0=A0=A0=A0=A0=A0 free_irq(i2c->irq, i2c);
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
next prev parent reply other threads:[~2005-05-16 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-16 6:24 [PATCH] i2c: Race fix for i2c-mpc.c Sylvain Munaut
2005-05-16 15:30 ` Kumar Gala [this message]
2005-05-16 16:06 ` Sylvain Munaut
2005-05-17 16:12 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5fe12cfac05d60b8af016382594e50db@freescale.com \
--to=kumar.gala@freescale.com \
--cc=a.llano@usyscom.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=tnt@246tNt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).