From: Segher Boessenkool <segher@kernel.crashing.org>
To: tony@bakeyournoodle.com (Tony Breeds)
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/3] Raise the upper limit of NR_CPUS.
Date: Tue, 22 Apr 2008 15:27:06 +0200 [thread overview]
Message-ID: <60054bf8803cb8f2a447c604447c6ae6@kernel.crashing.org> (raw)
In-Reply-To: <20080422055536.GI20457@bakeyournoodle.com>
>>> + unsigned long kernel_toc = (unsigned long)(&__toc_start) +
>>> 0x8000UL;
>>
>> This line could do with a comment saying what it is doing ...
>
> It does need a comment I agree, but I don't think I can do it justice
> :)
> ... I just used what was already there.
Here, have one:
"The TOC register (GPR2) points 32kB into the TOC, so that 64kB
of the TOC can be addressed using a single machine instruction."
or, perhaps simpler:
"The TOC register (GPR2) points 32kB into the TOC, because the
ABI says so."
Segher
prev parent reply other threads:[~2008-04-22 13:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-22 3:30 [PATCH 1/3] Raise the upper limit of NR_CPUS Tony Breeds
2008-04-22 3:30 ` [PATCH 3/3] Move the paca array into the BSS Tony Breeds
2008-04-22 3:30 ` [PATCH 2/3] Make iSeries spin on __secondary_hold_spinloop, like pSeries Tony Breeds
2008-04-22 4:02 ` Stephen Rothwell
2008-04-22 3:50 ` [PATCH 1/3] Raise the upper limit of NR_CPUS Stephen Rothwell
2008-04-22 5:55 ` Tony Breeds
2008-04-22 13:27 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60054bf8803cb8f2a447c604447c6ae6@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).