From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 75964DE02E for ; Tue, 22 Apr 2008 23:27:37 +1000 (EST) In-Reply-To: <20080422055536.GI20457@bakeyournoodle.com> References: <767e424a294239aba86aa7da086f6395f7066d14.1208834828.git.tony@bakeyournoodle.com> <20080422135005.16b4a65d.sfr@canb.auug.org.au> <20080422055536.GI20457@bakeyournoodle.com> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <60054bf8803cb8f2a447c604447c6ae6@kernel.crashing.org> From: Segher Boessenkool Subject: Re: [PATCH 1/3] Raise the upper limit of NR_CPUS. Date: Tue, 22 Apr 2008 15:27:06 +0200 To: tony@bakeyournoodle.com (Tony Breeds) Cc: Stephen Rothwell , Paul Mackerras , linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , >>> + unsigned long kernel_toc = (unsigned long)(&__toc_start) + >>> 0x8000UL; >> >> This line could do with a comment saying what it is doing ... > > It does need a comment I agree, but I don't think I can do it justice > :) > ... I just used what was already there. Here, have one: "The TOC register (GPR2) points 32kB into the TOC, so that 64kB of the TOC can be addressed using a single machine instruction." or, perhaps simpler: "The TOC register (GPR2) points 32kB into the TOC, because the ABI says so." Segher