From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rzpmC6rSRzDqpW for ; Wed, 27 Jul 2016 18:57:47 +1000 (AEST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6R8mplR114757 for ; Wed, 27 Jul 2016 04:57:45 -0400 Received: from e23smtp08.au.ibm.com (e23smtp08.au.ibm.com [202.81.31.141]) by mx0a-001b2d01.pphosted.com with ESMTP id 24dyqpkms2-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 27 Jul 2016 04:57:44 -0400 Received: from localhost by e23smtp08.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 Jul 2016 18:57:41 +1000 Received: from d23relay07.au.ibm.com (d23relay07.au.ibm.com [9.190.26.37]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 949E72BB0045 for ; Wed, 27 Jul 2016 18:57:38 +1000 (EST) Received: from d23av06.au.ibm.com (d23av06.au.ibm.com [9.190.235.151]) by d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u6R8vcsX25690130 for ; Wed, 27 Jul 2016 18:57:38 +1000 Received: from d23av06.au.ibm.com (localhost [127.0.0.1]) by d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u6R8vcV8031253 for ; Wed, 27 Jul 2016 18:57:38 +1000 Subject: Re: [PATCH] cxl: Delete an unnecessary check before the function call "of_node_put" To: Julia Lawall , SF Markus Elfring References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <33fb6b04-9986-35ee-f4e2-0ebeb79c5e23@users.sourceforge.net> Cc: Christophe Lombard , kernel-janitors@vger.kernel.org, LKML , Ian Munsie , linuxppc-dev@lists.ozlabs.org From: Andrew Donnellan Date: Wed, 27 Jul 2016 18:57:07 +1000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: <601fb58c-7aee-91ce-2a3d-7a29787968fc@au1.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 20/07/16 23:38, Julia Lawall wrote: > I don't think that the call should be there at all. The loop only exits > when afu_np is NULL. Furthermore, the loop should not be written as a for > loop, but rather with for_each_child_of_node. Will send a patch to fix both issues shortly. -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited