From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4846FC43334 for ; Wed, 29 Jun 2022 10:21:15 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4LXyD975Y4z3f89 for ; Wed, 29 Jun 2022 20:21:13 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.a=rsa-sha256 header.s=2022a header.b=X7tGIzHu; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=codeconstruct.com.au (client-ip=203.29.241.158; helo=codeconstruct.com.au; envelope-from=jk@codeconstruct.com.au; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=codeconstruct.com.au header.i=@codeconstruct.com.au header.a=rsa-sha256 header.s=2022a header.b=X7tGIzHu; dkim-atps=neutral X-Greylist: delayed 928 seconds by postgrey-1.36 at boromir; Wed, 29 Jun 2022 17:20:27 AEST Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4LXtCb1KPKz3bv4 for ; Wed, 29 Jun 2022 17:20:27 +1000 (AEST) Received: from pecola.lan (unknown [159.196.93.152]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id A134D2003E; Wed, 29 Jun 2022 15:03:54 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1656486296; bh=eOkMn4BdLyYJIY7WVcJ+BSTGLOGnPlIkZql9k18jmoA=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=X7tGIzHuAeR/JUSExm+e5NjDSQiwRlcdLfVuh9BkZ2pwDGDpHHek3GUutn7eXKhIE EpfLc4w6v3z3ma2rzovh8SXsx0UT6Lnr2obQLRC/B6zKPNgstpxn2MaLyeRg8ol+TC FLINtxlpAhbOodDw55rvd2YD5Xl7MpK6vuYF3VMycl4RQqdOBa3inRxzqeLpNKaY+p /7DFa6+k09qnV5w+CfRsa+Ldq7puU1Fz8pggPNk/5uHusxFiSYWyJk2W4DNn1lxElh eikxJ0l3lmiTV2R1HDTxFvJXUW2A/vCji2H+MMwMsJAaw+VUIG0cxjxBPsfraFCXVz eAIJyO4Km+y8Q== Message-ID: <60cc6796236f23c028a9ae76dbe00d1917df82a5.camel@codeconstruct.com.au> Subject: Re: [PATCH 6/6] i2c: Make remove callback return void From: Jeremy Kerr To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Wolfram Sang Date: Wed, 29 Jun 2022 15:03:54 +0800 In-Reply-To: <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> References: <20220628140313.74984-1-u.kleine-koenig@pengutronix.de> <20220628140313.74984-7-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.0-2 MIME-Version: 1.0 X-Mailman-Approved-At: Wed, 29 Jun 2022 20:19:09 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Ricardo Ribalda , Jimmy Su , Linus Walleij , Sekhar Nori , Gwendal Grignou , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Benjamin Tissoires , Paul Mackerras , Moses Christopher Bollavarapu , Pavel Machek , Miquel Raynal , Heikki Krogerus , Evgeniy Polyakov , Matt Johnston , Olli Salonen , Angela Czubak , Robert Marko , Luka Perkov , Sean Young , Dave Stevenson , Zheyu Ma , Javier Martinez Canillas , Chanwoo Choi , linux-omap@vger.kernel.org, An tti Palosaari , Wenyou Yang , Dongchun Zhu , Miaoqian Lin , Steve Longerbeam , Bingbu Cao , Shunqian Zheng , lijian , Dan Carpenter , Bartlomiej Zolnierkiewicz , Viorel Suman , Petr Machata , Guido =?ISO-8859-1?Q?G=FCnther?= , Jean Delvare , linux-serial@vger.kernel.org, linux-pm@vger.kernel.org, Eddie James , Riku Voipio , James Schulman , Scott Wood , Cai Huoqing , Jonas Malaco , Hsin-Yi Wang , Haibo Chen , Petr Cvek , linux-leds@vger.kernel.org, Joe Tessler , Andrey Konovalov , Andy Shevchenko , Robert Jones , George Joseph , Vincent Knecht , Robin van der Gracht , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, Michael Tretter , Geert Uytterhoeven , Phong LE , Daniel Beer , Krzysztof Opasiak , Bjorn Andersson , linux-crypto@vger.kernel.org, Pengutronix Kernel Team , Heungjun Kim , Hans Verkuil , David Lin , Vladimir Oltean , David Rhodes , Claudiu Beznea , Jean-Baptiste Maneyrol , Alexandre Belloni , Dan Robertson , Martyn Welch , Jiri Slaby , devicetree@vger.kernel.org, David Airlie , Jon Nettleton , Srinivas Pandruvada , Marco Felsch , Wim Van Sebroeck , Sebastian Reichel , Max Filippov , "Lad, Prabhakar" , Thierry Reding , linux-i2c@vger.kernel.org, Martiros Shakhzadyan , Guenter Roeck , Matthias Schwarzott , Sylwester Nawrocki , Eric Dumazet , Marek =?ISO-8859-1?Q?Beh=FAn?= , Saranya Gopal , Lars-Peter Clausen , Corey Minyard , Evgeny Novikov , Frank Rowand , Bartosz Golaszewski , Manivannan Sadhasivam , Pierr e-Louis Bossart , Minghao Chi , linux-clk@vger.kernel.org, Nathan Chancellor , MyungJoo Ham , Charles Gorand , Jagan Teki , Vijendar Mukunda , Miguel Ojeda , Kyungmin Park , Tianshu Qiu , Martin Donnelly , Woojung Huh , Rudolf Marek , Charles Keepax , linux-watchdog@vger.kernel.org, Michael Hennerich , Ido Schimmel , acpi4asus-user@lists.sourceforge.net, Simon Trimmer , Ricard Wanderlof , Rikard Falkeborn , Alex Deucher , Jiri Valek - 2N , linux-rpi-kernel@lists.infradead.org, Biju Das , Wa yne Chang , Chen-Yu Tsai , Sing-Han Chen , linux-arm-kernel@lists.infradead.org, Niklas =?ISO-8859-1?Q?S=F6derlund?= , Hans de Goede , Stephen Boyd , Maslov Dmitry , linux-gpio@vger.kernel.org, Jens Frederich , Douglas Anderson , linux-media@vger.kernel.org, "David S. Miller" , Paul Kocialkowski , Jarkko Sakkinen , linux-usb@vger.kernel.org, Jacopo Mondi , Maxime Coquelin , CGEL ZTE , Colin Leroy , platform-driver-x86@vger.kernel.org, linux-integrity@vger.kernel.org, Kevin Tsai , Pali =?ISO-8859-1?Q?Roh=E1r?= , Jonathan Cameron , Heiner Kallweit , Daniel Palmer , Arec Kao , Crt Mori , Jose Cazarin , Neil Armstrong , linux-iio@vger.kernel.org, Tom Rix , Michael Turquette , Peter Senna Tschudin , Benjamin Mugnier , Nuno =?ISO-8859-1?Q?S=E1?= , Jan-Simon Moeller , Wei Yongjun , Laurent Pinchart , Andrzej Hajda , Nikita Travkin , Jasmin Jessich , Sam Ravnborg , Kevin Cernekee , Alyssa Rosenzweig , linux-rtc@vger.kernel.org, Daniel Thompson , Florian Fainelli , Lucas Tanure , Stefan Mavrodiev , Masahiro Yamada , Sylvain Petinot , netdev@vger.kernel.org, Kieran Bingham , Jernej Skrabec , Xin Ji , Seven Lee , Matt Ranostay , Broadcom internal kernel review list , Adrien Grassein , Yang Yingliang , chrome-platform@lists.linux.dev, Mats Randgaard , Paolo Abeni , Alexey Dobriyan , Joel Stanley , linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Lyude Paul , Kees Cook , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Jonas Karlman , Yang Li , Tim Harvey , Jiri Kosina , Akinobu Mita , Mark Gross , Richard Fitzgerald , Mark Brown , wengjianfeng , Maxime Ripard , Sven Peter , Martin Kepplinger , openipmi-developer@lists.sourceforge.net, Mauro Carvalho Chehab , Benson Leung , "Daniel W. S. Almeida" , Chiranjeevi Rapolu , Alessandro Zummo , linux-hwmon@vger.kernel.org, Felipe Balbi , Stephan Gerhold , Support Opensource , Alexandru Ardelean , Dmitry Torokhov , Marc Hulsman , Corentin Chary , Stephen Kitt , Daniel Scally , linux-fbdev@vger.kernel.org, Andrey Ryabinin , Arnd Bergmann , Kirill Shilimanov , Sakari Ailus , patches@opensource.cirrus.com, Zheng Yongjun , Alejandro Tafalla , Peter Rosin , Arnaud Ferraris , Hector Martin , Vignesh Raghavendra , Nick Dyer , Greg Kroah-Hartman , Tony Lindgren , Alexandre Torgue , Takashi Iwai , Paul Cercueil , George McCollister , Mac Chiang , Antoniu Miclaus , Alexander Potapenko , linux-staging@lists.linux.dev, Adam Ford , Peter Huewe , UNGLinuxDriver@microchip.com, Lee Jones , linux-mtd@lists.infradead.org, Alexey Khoroshilov , Marek Vasut , Yizhuo , alsa-devel@alsa-project.org, Vinc enzo Frascino , Eric Piel , Herbert Xu , Tobias Schrammm , Richard Weinberger , Tomasz Duszynski , Janusz Krzysztofik , Russell King , linux-pwm@vger.kernel.org, Jason Gunthorpe , Thomas Zimmermann , Bastien Nocera , Jingoo Han , Jakub Kicinski , Vivien Didelot , Shawn Tu , Leon Luo , Yan Lei , Akihiro Tsukada , Tudor Ambarus , Dmitry Rokosov , Oliver Graute , Alistair Francis , Dongliang Mu , Jonathan =?ISO-8859-1?Q?Neusch=E4fer?= , Eduardo Valentin , Rui Miguel Silva , Michael Srba , Rob Herring , linux-mediatek@lists.infradead.org, Fabio Estevam , Matthias Brugger , kasan-dev@googlegroups.com, "Paul J. Murphy" , Nicola Lunghi , Daniele Alessandrelli , Dmitry Vyukov , Ramesh Shanmugasundaram , Liam Girdwood , Juerg Haefliger , Oder Chiou , Shengjiu Wang , Nicolas Ferre , Robert Foss , Krzysztof Kozlowski , Daniel Vetter , Alvin =?UTF-8?Q?=C5=A0ipraga?= , Luca Ceresoli , =?ISO-8859-1?Q?Jos=E9_Exp=F3sito?= , Johannes Berg , Colin Ian King , Maximilian Luz , Helge Deller , Lucas Stach Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Uwe, Looks good - just one minor change for the mctp-i2c driver, but only worthwhile if you end up re-rolling this series for other reasons: > -static int mctp_i2c_remove(struct i2c_client *client) > +static void mctp_i2c_remove(struct i2c_client *client) > =C2=A0{ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct mctp_i2c_client *m= cli =3D i2c_get_clientdata(client); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0struct mctp_i2c_dev *mide= v =3D NULL, *tmp =3D NULL; > @@ -1000,7 +1000,6 @@ static int mctp_i2c_remove(struct i2c_client *clien= t) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0mctp_i2c_free_client(mcli= ); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0mutex_unlock(&driver_clie= nts_lock); > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* Callers ignore return = code */ > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0return 0; > =C2=A0} The comment there no longer makes much sense, I'd suggest removing that too. Either way: Reviewed-by: Jeremy Kerr Cheers, Jeremy