linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Donnellan <ajd@linux.ibm.com>
To: nathanl@linux.ibm.com, Michael Ellerman <mpe@ellerman.id.au>,
	Nicholas Piggin <npiggin@gmail.com>,
	Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linuxppc-dev@lists.ozlabs.org,
	Mahesh Salgaonkar <mahesh@linux.ibm.com>,
	Hari Bathini <hbathini@linux.ibm.com>
Subject: Re: [PATCH v2 1/5] powerpc/rtas: Drop declaration of undefined call_rtas() function
Date: Mon, 20 Nov 2023 14:56:02 +1100	[thread overview]
Message-ID: <60d0540b743f6795827334ebc66199efae032cbf.camel@linux.ibm.com> (raw)
In-Reply-To: <20231114-rtas-trivial-v2-1-59cbab208d57@linux.ibm.com>

On Tue, 2023-11-14 at 11:22 -0600, Nathan Lynch via B4 Relay wrote:
> From: Nathan Lynch <nathanl@linux.ibm.com>
> 
> The call_rtas() function has never been a part of arch/powerpc, and
> its implementation was removed from arch/ppc by commit 0a26b1364f14
> ("ppc: Remove CHRP, POWER3 and POWER4 support from arch/ppc").
> 
> Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>

grep confirms this.

Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>

> ---
>  arch/powerpc/include/asm/rtas.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/powerpc/include/asm/rtas.h
> b/arch/powerpc/include/asm/rtas.h
> index c697c3c74694..3bf7f0a4b07e 100644
> --- a/arch/powerpc/include/asm/rtas.h
> +++ b/arch/powerpc/include/asm/rtas.h
> @@ -542,8 +542,6 @@ static inline void pSeries_coalesce_init(void) {
> }
>  static inline void rtas_initialize(void) { }
>  #endif
>  
> -extern int call_rtas(const char *, int, int, unsigned long *, ...);
> -
>  #ifdef CONFIG_HV_PERF_CTRS
>  void read_24x7_sys_info(void);
>  #else
> 

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@linux.ibm.com   IBM Australia Limited

  reply	other threads:[~2023-11-20  3:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-14 17:22 [PATCH v2 0/5] powerpc/rtas: Trivial and coding style fixes Nathan Lynch via B4 Relay
2023-11-14 17:22 ` [PATCH v2 1/5] powerpc/rtas: Drop declaration of undefined call_rtas() function Nathan Lynch via B4 Relay
2023-11-20  3:56   ` Andrew Donnellan [this message]
2023-11-14 17:22 ` [PATCH v2 2/5] powerpc/rtas: Remove unused rtas_service_present() Nathan Lynch via B4 Relay
2023-11-20  3:56   ` Andrew Donnellan
2023-11-14 17:22 ` [PATCH v2 3/5] powerpc/rtas: Move post_mobility_fixup() declaration to pseries Nathan Lynch via B4 Relay
2023-11-20  3:58   ` Andrew Donnellan
2023-11-14 17:22 ` [PATCH v2 4/5] powerpc/rtas: Remove trailing space Nathan Lynch via B4 Relay
2023-11-20  4:00   ` Andrew Donnellan
2023-11-14 17:22 ` [PATCH v2 5/5] powerpc/rtas: Remove 'extern' from function declarations in rtas.h Nathan Lynch via B4 Relay
2023-11-20  4:02   ` Andrew Donnellan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60d0540b743f6795827334ebc66199efae032cbf.camel@linux.ibm.com \
    --to=ajd@linux.ibm.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=hbathini@linux.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mahesh@linux.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=nathanl@linux.ibm.com \
    --cc=npiggin@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).