From: Joe Perches <joe@perches.com>
To: Chen Zhou <chenzhou10@huawei.com>,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
nivedita@alum.mit.edu, tglx@linutronix.de,
linuxppc-dev@lists.ozlabs.org, allison@lohutok.net
Subject: Re: [PATCH -next] powerpc/maple: fix comparing pointer to 0
Date: Mon, 20 Jan 2020 17:52:15 -0800 [thread overview]
Message-ID: <618f58cd46f0e4fd619cb2ee3c76665a28e30f4e.camel@perches.com> (raw)
In-Reply-To: <20200121013153.9937-1-chenzhou10@huawei.com>
On Tue, 2020-01-21 at 09:31 +0800, Chen Zhou wrote:
> Fixes coccicheck warning:
> ./arch/powerpc/platforms/maple/setup.c:232:15-16:
> WARNING comparing pointer to 0
Does anyone have or use these powerpc maple boards anymore?
Maybe the whole codebase should just be deleted instead.
If not, setup.c has an unused DBG macro that could be removed too.
---
arch/powerpc/platforms/maple/setup.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/powerpc/platforms/maple/setup.c b/arch/powerpc/platforms/maple/setup.c
index 47f7310..d6a083c 100644
--- a/arch/powerpc/platforms/maple/setup.c
+++ b/arch/powerpc/platforms/maple/setup.c
@@ -57,12 +57,6 @@
#include "maple.h"
-#ifdef DEBUG
-#define DBG(fmt...) udbg_printf(fmt)
-#else
-#define DBG(fmt...)
-#endif
-
static unsigned long maple_find_nvram_base(void)
{
struct device_node *rtcs;
next prev parent reply other threads:[~2020-01-21 2:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 1:31 [PATCH -next] powerpc/maple: fix comparing pointer to 0 Chen Zhou
2020-01-21 1:52 ` Joe Perches [this message]
2020-01-21 7:47 ` Segher Boessenkool
2020-01-21 11:15 ` Joe Perches
2020-01-29 5:17 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=618f58cd46f0e4fd619cb2ee3c76665a28e30f4e.camel@perches.com \
--to=joe@perches.com \
--cc=allison@lohutok.net \
--cc=benh@kernel.crashing.org \
--cc=chenzhou10@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nivedita@alum.mit.edu \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).