From: Segher Boessenkool <segher@kernel.crashing.org>
To: avorontsov@ru.mvista.com
Cc: linuxppc-dev@ozlabs.org, Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH 3/5] leds: implement OpenFirmare GPIO LEDs driver
Date: Sun, 30 Mar 2008 20:08:43 +0200 [thread overview]
Message-ID: <61b92a2a0440c1f93d2471365aae6e72@kernel.crashing.org> (raw)
In-Reply-To: <20080327171045.GA3266@localhost.localdomain>
> Here is updated patch with new linux,brightness OF property (needed for
> MPC8349E-mITX board -- pwr led should be "on" by default).
>
> p.s. I tend to do documentation as a separate patch: I don't want this
> patch to depend on the booting-without-of.txt -- it may produce
> conflicts easily.
We need to see that documentation first though: it is not documenting
this code, it is defining the device binding! Without it, we can
only guess whether this code is correct or not. Also, it is important
to decide on a binding before accepting this code.
If patches to booting-without-of.txt conflict often, we should split
it into a directory of files.
Segher
prev parent reply other threads:[~2008-03-30 18:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 20:24 [PATCH 3/5] leds: implement OpenFirmare GPIO LEDs driver Anton Vorontsov
2008-03-26 20:57 ` Grant Likely
2008-03-26 21:04 ` Matt Sealey
2008-03-26 23:07 ` Anton Vorontsov
2008-03-27 17:10 ` Anton Vorontsov
2008-03-30 18:08 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61b92a2a0440c1f93d2471365aae6e72@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=avorontsov@ru.mvista.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).