From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 98A12DDE19 for ; Mon, 31 Mar 2008 04:09:10 +1000 (EST) In-Reply-To: <20080327171045.GA3266@localhost.localdomain> References: <20080326202453.GC1772@localhost.localdomain> <20080327171045.GA3266@localhost.localdomain> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <61b92a2a0440c1f93d2471365aae6e72@kernel.crashing.org> From: Segher Boessenkool Subject: Re: [PATCH 3/5] leds: implement OpenFirmare GPIO LEDs driver Date: Sun, 30 Mar 2008 20:08:43 +0200 To: avorontsov@ru.mvista.com Cc: linuxppc-dev@ozlabs.org, Richard Purdie List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > Here is updated patch with new linux,brightness OF property (needed for > MPC8349E-mITX board -- pwr led should be "on" by default). > > p.s. I tend to do documentation as a separate patch: I don't want this > patch to depend on the booting-without-of.txt -- it may produce > conflicts easily. We need to see that documentation first though: it is not documenting this code, it is defining the device binding! Without it, we can only guess whether this code is correct or not. Also, it is important to decide on a binding before accepting this code. If patches to booting-without-of.txt conflict often, we should split it into a directory of files. Segher