From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Michael Jeanson <mjeanson@efficios.com>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Michal Suchanek <msuchanek@suse.de>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc/ftrace: fix syscall tracing on PPC64_ELF_ABI_V1
Date: Wed, 7 Dec 2022 16:26:54 +0000 [thread overview]
Message-ID: <61d98db6-68b3-1a5c-f59b-592048c742fd@csgroup.eu> (raw)
In-Reply-To: <6db50470-ac37-0328-37a2-760665668b5f@efficios.com>
Le 07/12/2022 à 16:18, Mathieu Desnoyers a écrit :
> On 2022-12-06 21:09, Michael Ellerman wrote:
>> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> writes:
>>> On 2022-12-05 17:50, Michael Ellerman wrote:
>>> IMHO the second option would be better because it does not increase the
>>> kernel image size as much as KALLSYMS_ALL.
>>
>> Yes I agree.
>>
>> Even if that did break something, any breakage would be limited to
>> arches which uses function descriptors, which are now all rare.
>
> Yes, it would only impact those arches using function descriptors, which
> are broken today with respect to system call tracing. Are you aware of
> other architectures other than PPC64 ELF ABI v1 supported by the Linux
> kernel that use function descriptors ?
$ git grep "select HAVE_FUNCTION_DESCRIPTORS" arch/
arch/ia64/Kconfig: select HAVE_FUNCTION_DESCRIPTORS
arch/parisc/Kconfig: select HAVE_FUNCTION_DESCRIPTORS if 64BIT
arch/powerpc/Kconfig: select HAVE_FUNCTION_DESCRIPTORS if
PPC64_ELF_ABI_V1
Christophe
next prev parent reply other threads:[~2022-12-07 16:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 16:14 [PATCH] powerpc/ftrace: fix syscall tracing on PPC64_ELF_ABI_V1 Michael Jeanson
2022-12-05 5:34 ` Michael Ellerman
2022-12-05 18:19 ` Michael Jeanson
2022-12-05 18:56 ` Christophe Leroy
2022-12-05 20:11 ` Michael Jeanson
2022-12-05 21:46 ` Michael Jeanson
2022-12-05 22:50 ` Michael Ellerman
2022-12-06 14:38 ` Mathieu Desnoyers
2022-12-06 23:08 ` Christophe Leroy
2022-12-07 2:09 ` Michael Ellerman
2022-12-07 15:18 ` Mathieu Desnoyers
2022-12-07 15:59 ` Michal Suchánek
2022-12-07 16:26 ` Christophe Leroy [this message]
2022-12-08 12:40 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61d98db6-68b3-1a5c-f59b-592048c742fd@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mjeanson@efficios.com \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
--cc=npiggin@gmail.com \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).