From: Kumar Gala <kumar.gala@freescale.com>
To: Tom Rini <trini@kernel.crashing.org>
Cc: linuxppc-dev list <linuxppc-dev@ozlabs.org>
Subject: Re: PATCH: add ppc PVR register values for 7447A and 7457 CPUs
Date: Wed, 23 Feb 2005 23:16:31 -0600 [thread overview]
Message-ID: <61dc898b0ce55c51093c2b1c44d65434@freescale.com> (raw)
In-Reply-To: <3609259af610006a1a0b7b016f727500@freescale.com>
Tom,
Here are the only usages of PVR_<CPU> that are in arch/ppc:
boot/simple/misc-ev64260.S: cmplwi r25,(PVR_7450 >> 16)
platforms/ev64260.c: if (pvr !=3D PVR_VER(PVR_7450)) {
platforms/4xx/ebony.c: case PVR_REV(PVR_440GP_RB):
platforms/4xx/ebony.c: case PVR_REV(PVR_440GP_RC1):
syslib/ibm440gx_common.c: if (pvr =3D=3D PVR_440GX_RA || pvr =3D=3D=20=
PVR_440GX_RB ||
syslib/ibm440gx_common.c: (pvr =3D=3D PVR_440GX_RC && p->cpu >=20=
667000000))
What do you think should we just get ride of all the other cases that=20
are not actually used and leave these in asm/regs.h or should we move=20
them as follows:
PVR_7450 -> into platforms/ev64260.h
PVR_440GP* -> into platforms/4xx/ebony.c (or include/asm/ibm4xx.h)
PVR_440GX* -> into syslib/ibm440gx_common.h
- kumar
On Feb 23, 2005, at 4:52 PM, Kumar Gala wrote:
>
>
> On Feb 23, 2005, at 4:25 PM, Tom Rini wrote:
>
> > On Wed, Feb 23, 2005 at 08:48:25PM +0000, James Chapman wrote:
> >=A0 > Signed-off-by: James Chapman <jchapman@katalix.com>
> > >
> > > Trivial patch to add 7447A and 7457 CPU defs.
> >
> > Why?=A0 Most of the PVR definitions here can be removed (*muttering=20=
> about
> >=A0 85xx ones being added).
>
> Yeah, yeah, will work on removing them.
>
> - kumar
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2005-02-24 5:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-23 20:48 PATCH: add ppc PVR register values for 7447A and 7457 CPUs James Chapman
2005-02-23 22:25 ` Tom Rini
2005-02-23 22:52 ` Kumar Gala
2005-02-24 5:16 ` Kumar Gala [this message]
2005-02-24 9:01 ` James Chapman
2005-02-24 14:18 ` Tom Rini
2005-02-24 15:50 ` James Chapman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61dc898b0ce55c51093c2b1c44d65434@freescale.com \
--to=kumar.gala@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).