Re: [PATCH v2] powerpc: 85xx: Add PHY fixup to socrates board code

[Kumar Gala <galak@kernel.crashing.org>]

On Apr 21, 2009, at 4:54 PM, Kumar Gala wrote:

>
> On Apr 21, 2009, at 12:19 PM, Anatolij Gustschin wrote:
>
>> If the firmware missed to initialize the PHY correctly,
>> Linux may hang up on socrates while eth0/eth1 interface
>> startup (caused by continuous unacknowledged PHY interrupt).
>>
>> This patch adds PHY fixup to socrates platform code to
>> ensure the PHY is pre-initialized correctly. It is needed
>> to be compatible with older firmware.
>>
>> Signed-off-by: Anatolij Gustschin <agust@denx.de>
>> ---
>> Changes since first version:
>> 	use macros instead of register numbers as
>> 	suggested by Anton
>>
>> Kumar, could you please consider this patch for
>> inclusion into 2.6.30? Thanks!
>
> Sorry.  I dont think this is board specific and should at a minimum  
> be done in m88e1011_config_init in drivers/net/phy/marvell.c.  Not  
> sure how 88E1011 differs from 88E1111, but I'm wondering if you  
> really want to set config_init for m88e1011 to m88e1111_config_init
>
> - k

I got confused by the #'s.. I think we should have a struct in  
marvell.c for m88e1121 which I'm guessing is the PHY you are using.

- k