From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B370C433B4 for ; Mon, 19 Apr 2021 13:14:52 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C0A88613AE for ; Mon, 19 Apr 2021 13:14:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C0A88613AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=csgroup.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FP6jk1bPbz3bpY for ; Mon, 19 Apr 2021 23:14:50 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=csgroup.eu (client-ip=93.17.236.30; helo=pegase1.c-s.fr; envelope-from=christophe.leroy@csgroup.eu; receiver=) Received: from pegase1.c-s.fr (pegase1.c-s.fr [93.17.236.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FP6jJ5SbKz2yQy for ; Mon, 19 Apr 2021 23:14:25 +1000 (AEST) Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 4FP6j54THDz9txv8; Mon, 19 Apr 2021 15:14:17 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id yKDNb47P5hGT; Mon, 19 Apr 2021 15:14:17 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 4FP6j53cN4z9txv7; Mon, 19 Apr 2021 15:14:17 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 866238B7B4; Mon, 19 Apr 2021 15:14:22 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id CgC9R0HVBL9q; Mon, 19 Apr 2021 15:14:22 +0200 (CEST) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id AB4DA8B7BD; Mon, 19 Apr 2021 15:14:21 +0200 (CEST) Subject: Re: [PATCH v1 3/5] mm: ptdump: Provide page size to notepage() To: Steven Price , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , akpm@linux-foundation.org References: <1ef6b954fb7b0f4dfc78820f1e612d2166c13227.1618506910.git.christophe.leroy@csgroup.eu> <41819925-3ee5-4771-e98b-0073e8f095cf@arm.com> <1102cda1-b00f-b6ef-6bf3-22068cc11510@arm.com> From: Christophe Leroy Message-ID: <627ee414-2f78-94e3-b77b-1013f52e77e3@csgroup.eu> Date: Mon, 19 Apr 2021 15:14:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <1102cda1-b00f-b6ef-6bf3-22068cc11510@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Le 16/04/2021 à 12:51, Steven Price a écrit : > On 16/04/2021 11:38, Christophe Leroy wrote: >> >> >> Le 16/04/2021 à 11:28, Steven Price a écrit : >>> On 15/04/2021 18:18, Christophe Leroy wrote: >>> >>> To be honest I don't fully understand why powerpc requires the page_size - it appears to be using >>> it purely to find "holes" in the calls to note_page(), but I haven't worked out why such holes >>> would occur. >> >> I was indeed introduced for KASAN. We have a first commit >> https://github.com/torvalds/linux/commit/cabe8138 which uses page size to detect whether it is a >> KASAN like stuff. >> >> Then came https://github.com/torvalds/linux/commit/b00ff6d8c as a fix. I can't remember what the >> problem was exactly, something around the use of hugepages for kernel memory, came as part of the >> series >> https://patchwork.ozlabs.org/project/linuxppc-dev/cover/cover.1589866984.git.christophe.leroy@csgroup.eu/ > > > Ah, that's useful context. So it looks like powerpc took a different route to reducing the KASAN > output to x86. > > Given the generic ptdump code has handling for KASAN already it should be possible to drop that from > the powerpc arch code, which I think means we don't actually need to provide page size to > notepage(). Hopefully that means more code to delete ;) > Looking at how the generic ptdump code handles KASAN, I'm a bit sceptic. IIUC, it is checking that kasan_early_shadow_pte is in the same page as the pgtable referred by the PMD entry. But what happens if that PMD entry is referring another pgtable which is inside the same page as kasan_early_shadow_pte ? Shouldn't the test be if (pmd_page_vaddr(val) == lm_alias(kasan_early_shadow_pte)) return note_kasan_page_table(walk, addr); Christophe