From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41qXzN04tBzF15Q for ; Tue, 14 Aug 2018 23:11:11 +1000 (AEST) Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w7EAERwA017751 for ; Tue, 14 Aug 2018 06:16:51 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2kuudhc5tw-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 14 Aug 2018 06:16:50 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 14 Aug 2018 11:16:49 +0100 Subject: Re: [PATCH] powerpc/perf: Update perf_regs structure to include SIER To: mpe@ellerman.id.au, Arnaldo Carvalho de Melo Cc: linuxppc-dev@lists.ozlabs.org, Jiri Olsa , Namhyung Kim , Alexander Shishkin , Anju T Sudhakar , Ravi Bangoria References: <1531218587-20742-1-git-send-email-maddy@linux.vnet.ibm.com> From: Madhavan Srinivasan Date: Tue, 14 Aug 2018 15:46:43 +0530 MIME-Version: 1.0 In-Reply-To: <1531218587-20742-1-git-send-email-maddy@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Message-Id: <6284589d-d8ef-da3d-c220-b6d5abf8c50e@linux.vnet.ibm.com> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi arnaldo, Any comments or ack for this patch. With regards Maddy On Tuesday 10 July 2018 03:59 PM, Madhavan Srinivasan wrote: > On each sample, Sample Instruction Event Register (SIER) content > is saved in pt_regs. SIER does not have a entry as-is in the pt_regs > but instead, SIER content is saved in the "dar" register of pt_regs. > > Patch adds another entry to the perf_regs structure to include the "SIER" > printing which internally maps to the "dar" of pt_regs. > > Cc: Arnaldo Carvalho de Melo > Cc: Jiri Olsa > Cc: Namhyung Kim > Cc: Alexander Shishkin > Cc: Anju T Sudhakar > Cc: Ravi Bangoria > Signed-off-by: Madhavan Srinivasan > --- > arch/powerpc/include/uapi/asm/perf_regs.h | 1 + > arch/powerpc/perf/perf_regs.c | 1 + > tools/arch/powerpc/include/uapi/asm/perf_regs.h | 1 + > tools/perf/arch/powerpc/include/perf_regs.h | 3 ++- > tools/perf/arch/powerpc/util/perf_regs.c | 1 + > 5 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/arch/powerpc/include/uapi/asm/perf_regs.h b/arch/powerpc/include/uapi/asm/perf_regs.h > index 9e52c86ccbd3..ff91192407d1 100644 > --- a/arch/powerpc/include/uapi/asm/perf_regs.h > +++ b/arch/powerpc/include/uapi/asm/perf_regs.h > @@ -46,6 +46,7 @@ enum perf_event_powerpc_regs { > PERF_REG_POWERPC_TRAP, > PERF_REG_POWERPC_DAR, > PERF_REG_POWERPC_DSISR, > + PERF_REG_POWERPC_SIER, > PERF_REG_POWERPC_MAX, > }; > #endif /* _UAPI_ASM_POWERPC_PERF_REGS_H */ > diff --git a/arch/powerpc/perf/perf_regs.c b/arch/powerpc/perf/perf_regs.c > index 09ceea6175ba..c262aea22ad9 100644 > --- a/arch/powerpc/perf/perf_regs.c > +++ b/arch/powerpc/perf/perf_regs.c > @@ -69,6 +69,7 @@ static unsigned int pt_regs_offset[PERF_REG_POWERPC_MAX] = { > PT_REGS_OFFSET(PERF_REG_POWERPC_TRAP, trap), > PT_REGS_OFFSET(PERF_REG_POWERPC_DAR, dar), > PT_REGS_OFFSET(PERF_REG_POWERPC_DSISR, dsisr), > + PT_REGS_OFFSET(PERF_REG_POWERPC_SIER, dar), > }; > > u64 perf_reg_value(struct pt_regs *regs, int idx) > diff --git a/tools/arch/powerpc/include/uapi/asm/perf_regs.h b/tools/arch/powerpc/include/uapi/asm/perf_regs.h > index 9e52c86ccbd3..ff91192407d1 100644 > --- a/tools/arch/powerpc/include/uapi/asm/perf_regs.h > +++ b/tools/arch/powerpc/include/uapi/asm/perf_regs.h > @@ -46,6 +46,7 @@ enum perf_event_powerpc_regs { > PERF_REG_POWERPC_TRAP, > PERF_REG_POWERPC_DAR, > PERF_REG_POWERPC_DSISR, > + PERF_REG_POWERPC_SIER, > PERF_REG_POWERPC_MAX, > }; > #endif /* _UAPI_ASM_POWERPC_PERF_REGS_H */ > diff --git a/tools/perf/arch/powerpc/include/perf_regs.h b/tools/perf/arch/powerpc/include/perf_regs.h > index 00e37b106913..1076393e6f43 100644 > --- a/tools/perf/arch/powerpc/include/perf_regs.h > +++ b/tools/perf/arch/powerpc/include/perf_regs.h > @@ -62,7 +62,8 @@ static const char *reg_names[] = { > [PERF_REG_POWERPC_SOFTE] = "softe", > [PERF_REG_POWERPC_TRAP] = "trap", > [PERF_REG_POWERPC_DAR] = "dar", > - [PERF_REG_POWERPC_DSISR] = "dsisr" > + [PERF_REG_POWERPC_DSISR] = "dsisr", > + [PERF_REG_POWERPC_SIER] = "sier" > }; > > static inline const char *perf_reg_name(int id) > diff --git a/tools/perf/arch/powerpc/util/perf_regs.c b/tools/perf/arch/powerpc/util/perf_regs.c > index ec50939b0418..07fcd977d93e 100644 > --- a/tools/perf/arch/powerpc/util/perf_regs.c > +++ b/tools/perf/arch/powerpc/util/perf_regs.c > @@ -52,6 +52,7 @@ const struct sample_reg sample_reg_masks[] = { > SMPL_REG(trap, PERF_REG_POWERPC_TRAP), > SMPL_REG(dar, PERF_REG_POWERPC_DAR), > SMPL_REG(dsisr, PERF_REG_POWERPC_DSISR), > + SMPL_REG(sier, PERF_REG_POWERPC_SIER), > SMPL_REG_END > }; >