From: Dan Williams <dan.j.williams@intel.com>
To: Shivaprasad G Bhat <sbhat@linux.ibm.com>, <nvdimm@lists.linux.dev>
Cc: ira.weiny@intel.com, aneesh.kumar@linux.ibm.com,
vaibhav@linux.ibm.com, dan.j.williams@intel.com,
linuxppc-dev@lists.ozlabs.org
Subject: RE: [REPOST PATCH] ndtest: Cleanup all of blk namespace specific code
Date: Tue, 12 Jul 2022 17:58:20 -0700 [thread overview]
Message-ID: <62ce18ac7164d_6070c294ce@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <165763940218.3501174.7103619358744815702.stgit@ltc-boston123.aus.stglabs.ibm.com>
Shivaprasad G Bhat wrote:
> With the nd_namespace_blk and nd_blk_region infrastructures being removed,
> the ndtest still has some references to the old code. So the
> compilation fails as below,
>
> ../tools/testing/nvdimm/test/ndtest.c:204:25: error: ‘ND_DEVICE_NAMESPACE_BLK’ undeclared here (not in a function); did you mean ‘ND_DEVICE_NAMESPACE_IO’?
> 204 | .type = ND_DEVICE_NAMESPACE_BLK,
> | ^~~~~~~~~~~~~~~~~~~~~~~
> | ND_DEVICE_NAMESPACE_IO
> ../tools/testing/nvdimm/test/ndtest.c: In function ‘ndtest_create_region’:
> ../tools/testing/nvdimm/test/ndtest.c:630:17: error: ‘ndbr_desc’ undeclared (first use in this function); did you mean ‘ndr_desc’?
> 630 | ndbr_desc.enable = ndtest_blk_region_enable;
> | ^~~~~~~~~
> | ndr_desc
> ../tools/testing/nvdimm/test/ndtest.c:630:17: note: each undeclared identifier is reported only once for each function it appears in
> ../tools/testing/nvdimm/test/ndtest.c:630:36: error: ‘ndtest_blk_region_enable’ undeclared (first use in this function)
> 630 | ndbr_desc.enable = ndtest_blk_region_enable;
> | ^~~~~~~~~~~~~~~~~~~~~~~~
> ../tools/testing/nvdimm/test/ndtest.c:631:35: error: ‘ndtest_blk_do_io’ undeclared (first use in this function); did you mean ‘ndtest_blk_mmio’?
> 631 | ndbr_desc.do_io = ndtest_blk_do_io;
> | ^~~~~~~~~~~~~~~~
> | ndtest_blk_mmio
>
> The current patch removes the specific code to cleanup all obsolete
> references.
>
> Signed-off-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>
Looks good, applied.
prev parent reply other threads:[~2022-07-13 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 15:23 [REPOST PATCH] ndtest: Cleanup all of blk namespace specific code Shivaprasad G Bhat
2022-07-13 0:58 ` Dan Williams [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62ce18ac7164d_6070c294ce@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=ira.weiny@intel.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nvdimm@lists.linux.dev \
--cc=sbhat@linux.ibm.com \
--cc=vaibhav@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).