From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.235]) by ozlabs.org (Postfix) with ESMTP id 6F4FCDDEEF for ; Mon, 23 Mar 2009 17:16:39 +1100 (EST) Received: by rv-out-0506.google.com with SMTP id g9so1555935rvb.9 for ; Sun, 22 Mar 2009 23:16:38 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <3A45394FD742FA419B760BB8D398F9ED2FA48E@zch01exm26.fsl.freescale.net> References: <3A45394FD742FA419B760BB8D398F9ED29EB95@zch01exm26.fsl.freescale.net> <49C3AB35.4080700@freescale.com> <3A45394FD742FA419B760BB8D398F9ED2FA48E@zch01exm26.fsl.freescale.net> Date: Mon, 23 Mar 2009 11:46:38 +0530 Message-ID: <62fe9ccc0903222316v6ef19b4akc24a2a72733c7718@mail.gmail.com> Subject: Re: suspend-to-mem on the mpc8349e-mitx-gp? From: MJ embd To: Li Yang-R58472 Content-Type: multipart/alternative; boundary=000e0cd14f6c8a21440465c3359d Cc: Wood Scott-B07421 , linuxppc-dev@ozlabs.org, Soohyung Cho List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --000e0cd14f6c8a21440465c3359d Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit "fsl,mpc8349-pmc" has .has_deep_sleep = 0, deep_sleeping=0 so the mem should not do anything and just do a standby. I am not sure if mem is a valid state in that case under /sys/power/state. Scott, u can fix it! -mj On Mon, Mar 23, 2009 at 11:15 AM, Li Yang-R58472 wrote: > > -----Original Message----- > > From: Wood Scott-B07421 > > Sent: Friday, March 20, 2009 10:42 PM > > To: Li Yang-R58472 > > Cc: Soohyung Cho; linuxppc-dev@ozlabs.org > > Subject: Re: suspend-to-mem on the mpc8349e-mitx-gp? > > > > Li Yang-R58472 wrote: > > >> However, the code should treat "mem" as "standby" on chips > > that don't > > >> support deep sleep. What does the device tree > > > > > > Well, shouldn't the valid() callback reject unsupported > > states instead > > > of covering up? > > > > I don't think so, in this case. The user is not asking for > > "sleep" or deep sleep"; they are asking for a power state > > that meets the definition of "standby" (which sleep does) or > > which meets the definition of "mem" > > (which both sleep and deep sleep do). When the user asks for > > "mem", we provide the lowest power mode that qualifies. > > In my understanding, "mem" which is suspend-to-ram means all CPU states and > registers are kept in memory and the CPU is completely off during > suspension. I don't think the sleep mode of 8349 qualifies, does it? > > - Leo > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev > --000e0cd14f6c8a21440465c3359d Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable 
"fsl,mpc8349-pmc" has .ha=
s_deep_sleep =3D 0, deep_sleeping=3D0 so the mem should not do anything and=
 just do a standby.
I am not sure=
 if mem is a valid state in that case under /sys/power/state. 
Scott, u can fix it!=

-mj

On Mon, Mar 23, 2009 at 11:15 AM, Li Yang= -R58472 <LeoLi@= freescale.com> wrote:
> -----Original Messag= e-----
> From: Wood Scott-B07421
> Sent: Friday, March 20, 2009 10:42 PM
> To: Li Yang-R58472
> Cc: Soohyung Cho; linuxppc-= dev@ozlabs.org
> Subject: Re: suspend-to-mem on the mpc8349e-mitx-gp?
>
> Li Yang-R58472 wrote:
> >> However, the code should treat "mem" as "stand= by" on chips
> that don't
> >> support deep sleep. =A0What does the device tree
> >
> > Well, shouldn't the valid() callback reject unsupported
> states instead
> > of covering up?
>
> I don't think so, in this case. =A0The user is not asking for
> "sleep" or deep sleep"; they are asking for a power sta= te
> that meets the definition of "standby" (which sleep does) or=
> which meets the definition of "mem"
> (which both sleep and deep sleep do). =A0When the user asks for
> "mem", we provide the lowest power mode that qualifies.

In my understanding, "mem" which is suspend-to-ram means al= l CPU states and registers are kept in memory and the CPU is completely off= during suspension. =A0I don't think the sleep mode of 8349 qualifies, = does it?

- Leo
_________________________________________= ______
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

--000e0cd14f6c8a21440465c3359d--