Re: [PATCH] BOOKE_WDT Part 1/2 (Re: PPC 44x Watchdog timer)

[Kumar Gala <kumar.gala@freescale.com>]

No problem, can you replace all the cmd line parsing with early_param()=20=

code in arch/ppc/kernel/setup.c.  Take a look at=20
arch/ppc64/kernel/setup.c for an example.  We still need to add a call=20=

to parse_early_param() in setup_arch().

Matt & I need to talk about the driver patch.  Once I have more=20
feedback on that I'll let you know.  The major issue I have is having=20
the interrupt handler in drivers/char/watchdog/.. instead of=20
arch/ppc/kernel/traps.c.  However, I dont have a good idea how to=20
structure the changes.

- kumar

On May 16, 2005, at 1:57 AM, Takeharu KATO wrote:

> Hi Kumar:
>
> I'm sorry that the reply becomes slow.
>
> Kumar Gala wrote:
>  >>
>  >
> > Any reason you moved this code into DecrementerHandler?
> >
> >>=A0=A0 /* 0x1000 - Programmable Interval Timer (PIT) Exception */
>  >>=A0=A0=A0=A0=A0=A0=A0=A0=A0 START_EXCEPTION(0x1000, Decrementer)
>  >>=A0 -=A0=A0=A0=A0=A0=A0 NORMAL_EXCEPTION_PROLOG
> >> -=A0=A0=A0=A0=A0=A0 lis=A0=A0=A0=A0 r0,TSR_PIS@h
> >> -=A0=A0=A0=A0=A0=A0 mtspr=A0=A0 SPRN_TSR,r0=A0=A0=A0=A0=A0=A0=A0=A0=A0=
=A0=A0=A0 /* Clear the PIT exception=20
> */
>  >>=A0 -=A0=A0=A0=A0=A0=A0 addi=A0=A0=A0 r3,r1,STACK_FRAME_OVERHEAD
> >> -=A0=A0=A0=A0=A0=A0 EXC_XFER_LITE(0x1000, timer_interrupt)
> >> +=A0=A0=A0=A0=A0=A0 b=A0=A0=A0 DecrementerHandler
> >>
>  Current PIT exception handler is too big.
>  If it is not moved, compilation is failed with relocation error.
>  Because current PIT handler overwrites WDT handler's codes, the=20
> compiler
> can not relocate PIT and WDT handler correctly.