From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FCD7C4345F for ; Fri, 26 Apr 2024 22:45:34 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=permerror header.d=arndb.de header.i=@arndb.de header.a=rsa-sha1 header.s=fm2 header.b=fghU94ch; dkim=permerror header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha1 header.s=fm3 header.b=YNcbk7Lb; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4VR7983cPLz3vxL for ; Sat, 27 Apr 2024 08:45:32 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=arndb.de header.i=@arndb.de header.a=rsa-sha256 header.s=fm2 header.b=fghU94ch; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=YNcbk7Lb; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=arndb.de (client-ip=103.168.172.138; helo=flow3-smtp.messagingengine.com; envelope-from=arnd@arndb.de; receiver=lists.ozlabs.org) Received: from flow3-smtp.messagingengine.com (flow3-smtp.messagingengine.com [103.168.172.138]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4VR0ML4Z7Tz3cYF for ; Sat, 27 Apr 2024 03:38:51 +1000 (AEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailflow.nyi.internal (Postfix) with ESMTP id E8F9B200569; Fri, 26 Apr 2024 13:38:47 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Fri, 26 Apr 2024 13:38:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1714153127; x=1714160327; bh=LvCKd10h8SxIpHH2VnKSem369EuCERsZx0vTF5ejpQk=; b= fghU94ch+kw2ZuohIgvUpuC7VVClQDJBilAiOlj5BDY+fjudFMBcDTAB7N01hvbn OQCPSfafmorkVmaA4fk0KMKEG4ggQZjF7sjgAkwhKPd01avbe3YP+yk0UcbLwU0h uAdX3Q6c7NuFHu0VlwQ+xwplD7oAhly0i5KgP3sO6E3b+Rz378b4mU3n4MWnDA9K y5e1rxlCgt2/upGSkwGFka+U4sLGacyQEpw5ZHF75lURalofPBr4V88yhxm43NZx inVj1S46mwU6OD3vpDFNumfH5SANQf1GD7soNFpGzE47AdQjVh99+mPKAMi6wwwq lo0RhaNfOyLtmZz/wwGksQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1714153127; x= 1714160327; bh=LvCKd10h8SxIpHH2VnKSem369EuCERsZx0vTF5ejpQk=; b=Y Ncbk7Lb+0iYLjTbQi54oAnvQ4BDt3H2OsTOrUiMRXTg96mXxQF6PJ5LqwrmZbK8F PHpA+bDLHotHe/9NBkqqNC/YAHtwNNR2OLpjYEFV0ghSAL25FjGCuUn8UG/8QB2B f2ZkRa0uP874nTjnn2UKAkf4OgxDUDbJzpNbQ3P7ebtgR6Kd6mJe1qnKAbuIuYYe WScAKDO+KPNaNSWVUMOcTkfHAroyws7ZMOe2TF13PdqOD62KMXJNsb7LtVdLnEPW +jZGlNDqV6bTs8j03XB8V/941Ob/a3J9oYeqI+yraB57y8L1aWKIXEtAO2ba70OM eBOJ/u+BcBBTHzSwQ/DEw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudelledgudduhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedf tehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrf grthhtvghrnhepgeefjeehvdelvdffieejieejiedvvdfhleeivdelveehjeelteegudek tdfgjeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprghrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 324F9B60099; Fri, 26 Apr 2024 13:38:42 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-386-g4cb8e397f9-fm-20240415.001-g4cb8e397 MIME-Version: 1.0 Message-Id: <63ae53af-023d-444c-9571-8aef9e87ebc0@app.fastmail.com> In-Reply-To: <20240426162042.191916-1-cgoettsche@seltendoof.de> References: <20240426162042.191916-1-cgoettsche@seltendoof.de> Date: Fri, 26 Apr 2024 19:38:18 +0200 From: "Arnd Bergmann" To: cgzones@googlemail.com Subject: Re: [PATCH v3 2/2] fs/xattr: add *at family syscalls Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Sat, 27 Apr 2024 08:44:02 +1000 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andreas Larsson , Mark Rutland , Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mips@vger.kernel.org, "James E . J . Bottomley" , Max Filippov , "H. Peter Anvin" , sparclinux@vger.kernel.org, Jan Kara , Alexander Gordeev , Will Deacon , Linux-Arch , linux-s390@vger.kernel.org, Paul Moore , Yoshinori Sato , Helge Deller , x86@kernel.org, Russell King , "Aneesh Kumar K.V" , Ingo Molnar , Geert Uytterhoeven , "Naveen N. Rao" , Matt Turner , Christian Borntraeger , Miklos Szeredi , Palmer Dabbelt , Kees Cook , Vasily Gorbik , selinux@vger.kernel.org, Heiko Carstens , Richard Henderson , Christian Brauner , Nicholas Piggin , Casey Schaufler , linux-m68k@lists.linux-m68k.org, Ivan Kokshaysky , Alexander Viro , Andy Lutomirski , John Paul Adrian Glaubitz , Sohil Mehta , Thomas Gleixner , io-uring@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jens Axboe , Chris Zankel , Michal Simek , Thomas Bogendoerfer , Nhat Pham , Florian Fainelli , linux-parisc@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Paris , Pavel Begunkov , audit@vger.kernel.org, linux-security-module@vger.kernel.org, Sven Schnelle , linux-alpha@vger.kernel.org, linux-fsdevel@vger.kernel.org, Borislav Petkov , Rick Edgecombe , linuxppc-dev@lists.ozlabs.org, "David S . Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Apr 26, 2024, at 18:20, Christian G=C3=B6ttsche wrote: > From: Christian G=C3=B6ttsche > > Add the four syscalls setxattrat(), getxattrat(), listxattrat() and > removexattrat(). Those can be used to operate on extended attributes, > especially security related ones, either relative to a pinned directory > or on a file descriptor without read access, avoiding a > /proc//fd/ detour, requiring a mounted procfs. > > One use case will be setfiles(8) setting SELinux file contexts > ("security.selinux") without race conditions and without a file > descriptor opened with read access requiring SELinux read permission. > > Use the do_{name}at() pattern from fs/open.c. > > Pass the value of the extended attribute, its length, and for > setxattrat(2) the command (XATTR_CREATE or XATTR_REPLACE) via an added > struct xattr_args to not exceed six syscall arguments and not > merging the AT_* and XATTR_* flags. > > Signed-off-by: Christian G=C3=B6ttsche > CC: x86@kernel.org > CC: linux-alpha@vger.kernel.org > CC: linux-kernel@vger.kernel.org > CC: linux-arm-kernel@lists.infradead.org > CC: linux-ia64@vger.kernel.org > CC: linux-m68k@lists.linux-m68k.org > CC: linux-mips@vger.kernel.org > CC: linux-parisc@vger.kernel.org > CC: linuxppc-dev@lists.ozlabs.org > CC: linux-s390@vger.kernel.org > CC: linux-sh@vger.kernel.org > CC: sparclinux@vger.kernel.org > CC: linux-fsdevel@vger.kernel.org > CC: audit@vger.kernel.org > CC: linux-arch@vger.kernel.org > CC: linux-api@vger.kernel.org > CC: linux-security-module@vger.kernel.org > CC: selinux@vger.kernel.org I checked that the syscalls are all well-formed regarding argument types, number of arguments and (absence of) compat handling, and that they are wired up correctly across architectures I did not look at the actual implementation in detail. Reviewed-by: Arnd Bergmann