From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH v4 3/6] kprobes: Skip preparing optprobe if the probe is ftrace-based
Date: Wed, 19 Apr 2017 18:22:25 +0530 [thread overview]
Message-ID: <63c796a86e56ae64e88ba1fc55ca864789c9b22e.1492606062.git.naveen.n.rao@linux.vnet.ibm.com> (raw)
In-Reply-To: <cover.1492605029.git.naveen.n.rao@linux.vnet.ibm.com>
In-Reply-To: <cover.1492606062.git.naveen.n.rao@linux.vnet.ibm.com>
From: Masami Hiramatsu <mhiramat@kernel.org>
Skip preparing optprobe if the probe is ftrace-based, since anyway, it
must not be optimized (or already optimized by ftrace).
Tested-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
kernel/kprobes.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/kernel/kprobes.c b/kernel/kprobes.c
index bb86681c8a10..50c48c5b6490 100644
--- a/kernel/kprobes.c
+++ b/kernel/kprobes.c
@@ -743,13 +743,20 @@ static void kill_optimized_kprobe(struct kprobe *p)
arch_remove_optimized_kprobe(op);
}
+static inline
+void __prepare_optimized_kprobe(struct optimized_kprobe *op, struct kprobe *p)
+{
+ if (!kprobe_ftrace(p))
+ arch_prepare_optimized_kprobe(op, p);
+}
+
/* Try to prepare optimized instructions */
static void prepare_optimized_kprobe(struct kprobe *p)
{
struct optimized_kprobe *op;
op = container_of(p, struct optimized_kprobe, kp);
- arch_prepare_optimized_kprobe(op, p);
+ __prepare_optimized_kprobe(op, p);
}
/* Allocate new optimized_kprobe and try to prepare optimized instructions */
@@ -763,7 +770,7 @@ static struct kprobe *alloc_aggr_kprobe(struct kprobe *p)
INIT_LIST_HEAD(&op->list);
op->kp.addr = p->addr;
- arch_prepare_optimized_kprobe(op, p);
+ __prepare_optimized_kprobe(op, p);
return &op->kp;
}
--
2.12.1
next prev parent reply other threads:[~2017-04-19 12:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 12:52 [PATCH v4 0/6] powerpc: add support for KPROBES_ON_FTRACE Naveen N. Rao
[not found] ` <cover.1492606062.git.naveen.n.rao@linux.vnet.ibm.com>
2017-04-19 12:52 ` [PATCH v4 1/6] powerpc: ftrace: minor cleanup Naveen N. Rao
2017-04-23 11:53 ` [v4,1/6] " Michael Ellerman
2017-04-19 12:52 ` [PATCH v4 2/6] powerpc: ftrace: restore LR from pt_regs Naveen N. Rao
2017-04-24 22:47 ` [v4,2/6] " Michael Ellerman
2017-04-19 12:52 ` Naveen N. Rao [this message]
2017-04-24 22:47 ` [v4, 3/6] kprobes: Skip preparing optprobe if the probe is ftrace-based Michael Ellerman
2017-04-19 12:52 ` [PATCH v4 4/6] powerpc: kprobes: add support for KPROBES_ON_FTRACE Naveen N. Rao
2017-04-24 22:47 ` [v4,4/6] " Michael Ellerman
2017-04-19 12:52 ` [PATCH v4 5/6] powerpc: introduce a new helper to obtain function entry points Naveen N. Rao
2017-04-24 22:47 ` [v4, " Michael Ellerman
2017-04-19 12:52 ` [PATCH v4 6/6] powerpc: kprobes: prefer ftrace when probing function entry Naveen N. Rao
2017-04-24 22:47 ` [v4, " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63c796a86e56ae64e88ba1fc55ca864789c9b22e.1492606062.git.naveen.n.rao@linux.vnet.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).