From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: Daniel Axtens <dja@axtens.net>
Subject: Re: [PATCH v2 1/5] powerpc/cell: drop unused iic_get_irq_host()
Date: Thu, 08 Sep 2016 09:44:17 +0200 [thread overview]
Message-ID: <6411576.kd9HS3NQth@wuerfel> (raw)
In-Reply-To: <1473139963-7496-1-git-send-email-dja@axtens.net>
On Tuesday, September 6, 2016 3:32:39 PM CEST Daniel Axtens wrote:
> Sparse checking revealed that it is no longer used.
> There is an EXPORT_SYMBOL_GPL, but there's no header that
> provides a prototype, so nothing should be using it anyway.
>
> Remove it.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Good catch!
I'm currently experimenting with a patch that adds -Wmissing-declaration to
the normal kernel CFLAGS for everyone, and fixing up the warnings I get with
that on ARM.
Are you looking at all the powerpc specific code? If we can catch all the
existing warnings for some of the major architectures, we can hopefully
enable this in the mainline kernel at some point so we don't need sparse
for it any more.
Arnd
next prev parent reply other threads:[~2016-09-08 7:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 5:32 [PATCH v2 1/5] powerpc/cell: drop unused iic_get_irq_host() Daniel Axtens
2016-09-06 5:32 ` [PATCH v2 2/5] powerpc/sparse: Make a bunch of things static Daniel Axtens
2016-09-13 12:16 ` [v2,2/5] " Michael Ellerman
2016-09-14 0:11 ` [PATCH v2 2/5] " Michael Ellerman
2016-09-06 5:32 ` [PATCH v2 3/5] powerpc/kvm: sparse: prototypes for functions called from assembler Daniel Axtens
2016-09-06 5:32 ` [PATCH v2 4/5] powerpc/fadump: Make ELF eflags depend on endian Daniel Axtens
2016-09-08 7:00 ` Mahesh Jagannath Salgaonkar
2016-09-08 8:21 ` Mahesh Jagannath Salgaonkar
2016-09-09 10:58 ` Michael Ellerman
2016-09-08 9:17 ` Michael Ellerman
2016-09-08 9:35 ` Michael Ellerman
2016-09-13 12:16 ` [v2,4/5] " Michael Ellerman
2016-09-06 5:32 ` [PATCH v2 5/5] powerpc/sparse: Add more assembler prototypes Daniel Axtens
2016-09-13 12:16 ` [v2,5/5] " Michael Ellerman
2016-09-06 6:01 ` [PATCH v2 1/5] powerpc/cell: drop unused iic_get_irq_host() Andrew Donnellan
2016-09-08 7:44 ` Arnd Bergmann [this message]
2016-09-09 0:43 ` Daniel Axtens
2016-09-09 1:14 ` Andrew Donnellan
2016-09-09 7:42 ` Arnd Bergmann
2016-09-13 12:16 ` [v2,1/5] " Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6411576.kd9HS3NQth@wuerfel \
--to=arnd@arndb.de \
--cc=dja@axtens.net \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).