From: Tillmann Heidsieck <theidsieck@leenox.de>
To: Scott Wood <oss@buserror.net>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/fsl_pci: Size upper inbound window based on RAM size
Date: Fri, 26 Aug 2016 09:05:02 +0200 [thread overview]
Message-ID: <644493115e473879edacfbbb1df80ec2@mail.leenox.de> (raw)
In-Reply-To: <1472193505-13136-1-git-send-email-oss@buserror.net>
Hi Scott,
thanks for the patch! This one works for my setup:
T4240, 12GB Ram and Radeon E6760.
On 2016-08-26 08:38, Scott Wood wrote:
> This allows PCI devices that can only address (e.g.) 36 or 40 bit DMA
> to
> use direct DMA, at the cost of not being able to DMA to non-RAM
> addresses
> (this doesn't affect MSIs as there is a separate dedicated window for
> that) which we wouldn't have been able to do anyway if the RAM size
> didn't
> trigger the creation of the second inbound window.
>
> It also fixes an off-by-one error that set dma_direct_ops on PCI
> devices
> whose dma mask could address all the space below the DMA offset
> (previously 40 bits), but not the window that starts at the DMA offset.
>
> Signed-off-by: Scott Wood <oss@buserror.net>
> Cc: Tillmann Heidsieck <theidsieck@leenox.de>
> ---
Tested-by: Tillmann Heidsieck <theidsieck@leenox.de>
prev parent reply other threads:[~2016-08-26 7:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-26 6:38 [PATCH] powerpc/fsl_pci: Size upper inbound window based on RAM size Scott Wood
2016-08-26 7:05 ` Tillmann Heidsieck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=644493115e473879edacfbbb1df80ec2@mail.leenox.de \
--to=theidsieck@leenox.de \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).