From: Scott Wood <oss@buserror.net>
To: Darren Stevens <darren@stevens-zone.net>
Cc: linuxppc-dev@lists.ozlabs.org, chzigotzky@xenosoft.de
Subject: Re: powerpc/mpc85xx: Add Cyrus P5040 device tree source
Date: Thu, 14 May 2020 01:42:55 -0500 [thread overview]
Message-ID: <6456c742fa178b54aadff5f0d4d7f28cb47c93a2.camel@buserror.net> (raw)
In-Reply-To: <4fb03d6874.55cfc4a1@auth.smtp.1and1.co.uk>
On Wed, 2020-05-13 at 23:02 +0100, Darren Stevens wrote:
> Hello Scott
>
> On 08/05/2020, Scott Wood wrote:
> > On Thu, 2020-05-07 at 22:30 +0100, Darren Stevens wrote:
> > >
> > > +/include/ "p5040si-pre.dtsi"
> > > +
> > > +/ {
> > > + model = "varisys,CYRUS5040";
> > > + compatible = "varisys,CYRUS";
> >
> > Is this board 100% compatible with the Cyrus P5020 board, down to every
> > last
> > quirk, except for the SoC plugged into it? If not, they shouldn't have
> > the
> > same compatible. If they are, then couldn't everything in this file but
> > the
> > SoC include be moved to a dtsi shared with cyrus_p5020.dts?
>
> It's not 100% compatible, the mdio ports map to different fman ports, but
> both as are 'corenet generic' boards, I added varisys,CYRUS so it would be
> detected in corenet_generic.c - support for the 5020 was added by Andy
> Flemming, I've just tried to copy what he did.
>
> I can add another entry to the table, but do we realy want a separate entry
> in the table for every supported board rather than using the device tree for
> similar boards?
A separate compatible for each board is generally what we've done, as it
allows for the possibility of board-specific quirks. At least it's just a
table entry; back in the day it used to be a separate file. :-P
That said, if you're pretty sure that all potentially relevant differences are
described elsewhere in the device tree, I wouldn't mind too much if it
becomes:
compatible = "varisys,CYRUS5040", "varisys,CYRUS";
-Scott
prev parent reply other threads:[~2020-05-14 6:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 21:30 [PATCH 5/5] powerpc/mpc85xx: Add Cyrus P5040 device tree source Darren Stevens
2020-05-08 20:42 ` Scott Wood
2020-05-13 22:02 ` Darren Stevens
2020-05-14 6:42 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6456c742fa178b54aadff5f0d4d7f28cb47c93a2.camel@buserror.net \
--to=oss@buserror.net \
--cc=chzigotzky@xenosoft.de \
--cc=darren@stevens-zone.net \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).