From: "Torsten Kaiser" <just.for.lkml@googlemail.com>
To: "Trond Myklebust" <trond.myklebust@fys.uio.no>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
steved@redhat.com, LKML <linux-kernel@vger.kernel.org>,
Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
linuxppc-dev@ozlabs.org, nfs@lists.sourceforge.net,
Andrew Morton <akpm@linux-foundation.org>,
Jan Blunck <jblunck@suse.de>, Ingo Molnar <mingo@elte.hu>,
Balbir Singh <balbir@linux.vnet.ibm.com>
Subject: Re: [BUG] 2.6.24-rc2-mm1 - kernel bug on nfs v4
Date: Mon, 19 Nov 2007 08:15:48 +0100 [thread overview]
Message-ID: <64bb37e0711182315s1d159c80h11811acb07566f03@mail.gmail.com> (raw)
In-Reply-To: <1195413486.7893.16.camel@heimdal.trondhjem.org>
On Nov 18, 2007 8:18 PM, Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> On Sun, 2007-11-18 at 19:44 +0100, Torsten Kaiser wrote:
> > NFSv2/3 and NFSv4 share the same dentry_iput and so share the same
> > unlink and sillyrename logic.
> > But they do not share nfs_init_server()!
> >
> > I wonder why this doesn't blow up more violently, but only hangs...
> >
> > But as I don't know if it is correct to add the workqueue
> > initialization to nfs4_init_server() or remove the nfs_sb_active /
> > nfs_sb_deactive for the NFSv4 case, I can't offer a patch to fix this.
> >
> > Torsten
>
> I had already fixed that one in my own stack. Attached are the 3 patches
> that I've got. 1 from SteveD, 2 fixes.
>
Moving the init_waitqueue_head() like patch
linux-2.6.24-006-fix_to_fix_sillyrename_bug_on_umount.dif and applying
linux-2.6.24-007-fix_nfs_free_unlinkdata.dif lets my testcase work.
Also lockdep no longer complains about the non-static key.
Torsten
next prev parent reply other threads:[~2007-11-19 7:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 14:15 [BUG] 2.6.24-rc2-mm1 - kernel bug on nfs v4 Kamalesh Babulal
2007-11-17 17:53 ` Torsten Kaiser
2007-11-17 18:05 ` Andrew Morton
2007-11-17 19:33 ` Christoph Lameter
2007-11-17 20:10 ` Torsten Kaiser
2007-11-17 18:09 ` Ingo Molnar
2007-11-17 18:19 ` Andrew Morton
2007-11-17 19:40 ` Torsten Kaiser
2007-11-17 23:05 ` Peter Zijlstra
2007-11-17 23:44 ` Torsten Kaiser
2007-11-18 18:44 ` Torsten Kaiser
2007-11-18 19:18 ` Trond Myklebust
2007-11-19 7:15 ` Torsten Kaiser [this message]
2007-11-19 9:00 ` Andrew Morton
2007-11-19 18:24 ` Torsten Kaiser
2007-11-20 5:35 ` Andrew Morton
2007-11-17 23:00 ` root
2007-11-19 22:50 ` Christoph Lameter
2007-11-17 18:58 ` Trond Myklebust
2007-11-17 19:18 ` Torsten Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64bb37e0711182315s1d159c80h11811acb07566f03@mail.gmail.com \
--to=just.for.lkml@googlemail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=jblunck@suse.de \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mingo@elte.hu \
--cc=nfs@lists.sourceforge.net \
--cc=steved@redhat.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).