From: Geoff Levand <geoff@infradead.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: linuxppc-dev@lists.ozlabs.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
Markus Elfring <elfring@users.sourceforge.net>,
Emmanuel Nicolet <emmanuel.nicolet@gmail.com>
Subject: Re: [PATCH v2 7/9] powerpc/ps3: Add check for otheros image size
Date: Sat, 16 May 2020 09:03:29 -0700 [thread overview]
Message-ID: <65353693-f082-42eb-aa89-ab11ea5f623b@infradead.org> (raw)
In-Reply-To: <87y2pu9cqd.fsf@mpe.ellerman.id.au>
Hi Michael,
On 5/14/20 7:02 PM, Michael Ellerman wrote:
> Geoff Levand <geoff@infradead.org> writes:
...
>> + # The ps3's flash loader has a size limit of 16 MiB for the uncompressed
>> + # image. If a compressed image that exceeded this limit is written to
>> + # flash the loader will decompress that image until the 16 MiB limit is
>> + # reached, then enter the system reset vector of the partially decompressed
>> + # image. No warning is issued.
>> + rm -f "$odir"/{otheros,otheros-too-big}.bld
>> + size=$(${CROSS}nm --no-sort --radix=d "$ofile" | egrep ' _end$' | cut -d' ' -f1)
>> + bld="otheros.bld"
>> + if [ $size -gt $((0x1000000)) ]; then
>> + bld="otheros-too-big.bld"
>> + echo " INFO: Uncompressed kernel is too large to program into PS3 flash memory;" \
>
> This now appears on all my ppc64_defconfig builds, which I don't really
> like.
No, neither do I. I didn't think of that case.
> That does highlight the fact that ppc64_defconfig including
> CONFIG_PPC_PS3 is not really helpful for people actually wanting to run
> the kernel on a PS3.
No, this is just for the bootloader image (.bld) that can be
programed into flash memory. This is what is used to create,
for example, a petitboot bootloader image.
Normal usage is for the bootloader in flash to load a vmlinux
image from disk or network, in which case running a ppc64_defconfig
image would be fine.
> So I wonder if we should drop CONFIG_PPC_PS3 from ppc64_defconfig, in
> which case I'd be happy to keep the INFO message because it should only
> appear on ps3 specific builds.
I'd like to keep CONFIG_PPC_PS3 set in ppc64_defconfig. I feel it
useful to get some build testing of the PS3 platform code.
> The other option would be to drop the message, or only print it when
> we're doing a verbose build.
Building a boatloader image to program into flash memory is
something only very advanced users would be doing. I don't
think they would need this message. They would see the file
name and understand the situation. I'll post a v3 patch that
removes the message.
-Geoff
next prev parent reply other threads:[~2020-05-16 16:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 18:58 [PATCH v2 0/9] powerpc + ps3 patches Geoff Levand
2020-05-09 18:58 ` [PATCH v2 2/9] powerpc/wrapper: Output linker map file Geoff Levand
2020-05-09 18:58 ` [PATCH v2 3/9] powerpc/head_check: Avoid broken pipe Geoff Levand
2020-05-09 18:58 ` [PATCH v2 1/9] powerpc/head_check: Automatic verbosity Geoff Levand
2020-05-09 18:58 ` [PATCH v2 4/9] drivers/ps3: Remove duplicate error messages Geoff Levand
2020-05-10 18:15 ` Markus Elfring
2020-05-09 18:58 ` [PATCH v2 5/9] net/ps3_gelic_net: Remove duplicate error message Geoff Levand
2020-05-10 18:25 ` Markus Elfring
2020-05-09 18:58 ` [PATCH v2 9/9] hvc_console: Allow backends to set I/O buffer size Geoff Levand
2020-05-10 19:05 ` Markus Elfring
2020-05-10 22:50 ` [PATCH v3 " Geoff Levand
2020-05-09 18:58 ` [PATCH v2 7/9] powerpc/ps3: Add check for otheros image size Geoff Levand
2020-05-15 2:02 ` Michael Ellerman
2020-05-16 16:03 ` Geoff Levand [this message]
2020-05-18 6:31 ` Michael Ellerman
2020-05-16 16:20 ` [PATCH v3 " Geoff Levand
2020-06-09 5:56 ` Michael Ellerman
2020-05-09 18:58 ` [PATCH v2 8/9] powerpc/ps3: Fix kexec shutdown hang Geoff Levand
2020-05-09 18:58 ` [PATCH v2 6/9] ps3disk: use the default segment boundary Geoff Levand
2020-05-20 10:59 ` [PATCH v2 0/9] powerpc + ps3 patches Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2020-03-27 20:26 [PATCH 0/9] PS3 patches for v5.7 Geoff Levand
2020-03-27 20:26 ` [PATCH 7/9] powerpc/ps3: Add check for otheros image size Geoff Levand
2020-03-30 3:11 ` [PATCH V2 " Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65353693-f082-42eb-aa89-ab11ea5f623b@infradead.org \
--to=geoff@infradead.org \
--cc=elfring@users.sourceforge.net \
--cc=emmanuel.nicolet@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).