From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 142CFC3065A for ; Mon, 1 Jul 2024 14:53:21 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=oM/+2upB; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4WCTYq58nrz3dBm for ; Tue, 2 Jul 2024 00:53:19 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=oM/+2upB; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=jarkko@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4WCTY43ZVfz30Wg for ; Tue, 2 Jul 2024 00:52:40 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5D1F46146E; Mon, 1 Jul 2024 14:52:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC54DC116B1; Mon, 1 Jul 2024 14:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719845557; bh=p9YfnGbtHLfEIX8p3mNY3/6BkKuqCdHuCCiSXutUbIo=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=oM/+2upBDtZEj0r91Tqkmmg5mXJ6AoyvHu3pAqjHLI3lKmG2+YoGCGQS1//g2O37W XYoZel02aU09rtL4WEhgzxhYNEYIT//n5qMkHITDC4ndG09KPjUbuJEKW5ngBTnkEV geyPxQOC8eLbnHh8O9YllCmRf1UPK3a55VU/yuoNk/1BigWO4Nggoq06zxHdPDJQc6 /Doso1JNA8cO6fecnaCmDV2eFQw1GKZxwNe4rTZogBiIJhlox1swQ8Zh2fkgklSssz Y4gkxxEeOtIIOfYFglBRYqgGKqov9GQ27BbRqLXrW9De1rQkbFNsa6DKduApzrWxdM JBwPXzlBBKZZQ== Message-ID: <656b319fc58683e399323b880722434467cf20f2.camel@kernel.org> Subject: Re: [PATCH] tpm: ibmvtpm: Call tpm2_sessions_init() to initialize session support From: Jarkko Sakkinen To: Stefan Berger , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Date: Mon, 01 Jul 2024 14:52:33 +0000 In-Reply-To: <20240617193408.1234365-1-stefanb@linux.ibm.com> References: <20240617193408.1234365-1-stefanb@linux.ibm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) MIME-Version: 1.0 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: naveen.n.rao@linux.ibm.com, linux-kernel@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, 2024-06-17 at 15:34 -0400, Stefan Berger wrote: > Fix the following type of error message caused by a missing call to > tpm2_sessions_init() in the IBM vTPM driver: >=20 > [=C2=A0=C2=A0=C2=A0 2.987131] tpm tpm0: tpm2_load_context: failed with a = TPM error 0x01C4 > [=C2=A0=C2=A0=C2=A0 2.987140] ima: Error Communicating to TPM chip, resul= t: -14 >=20 > Fixes: d2add27cf2b8 ("tpm: Add NULL primary creation") > Signed-off-by: Stefan Berger This is a bug in the hmac encryption. It should be robust enough to only be enabled if tpm_sessions_init() was called. It is fine to enable the feature IBM vTPM driver but definitely not as a bug fix. Missed this one in the code review. BR, Jarkko