From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 14A50CD6E55 for ; Wed, 3 Jun 2026 08:12:56 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4gVgRp34crz2ybQ; Wed, 03 Jun 2026 18:12:54 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1780474374; cv=none; b=Nfm9UVgYlKw/F1kXqAkGbW3HZ6XdTKZVpqm3Kvr9apQVrztAQ5SprrX8U1Iiz6ci+M5Tn7HL5Cpu6uBr7K+7BxEPWPPH9ACVQN0O+SGBZiQjxHkC/jaU80tpI3NL147J+uQXw7460sgo5t5E0awh5tCOkyCkofl0gXreTqKWCZlc8x1TJTJCDpUMYlwUuj9nkP6fPQ1SBKewbMljgXQLyoGfyhiQYn8lCFDnrHDqL78pKyY60ex7wZE7Z+CEv+aXlBBb8/1OU32ToBcybvPs4Q6/XZxReUYXMcdsFH2eQrcmOE6e95JoBoPCC9IpzoH1/oMoAeYcbXTQTtTvf0XvIg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1780474374; c=relaxed/relaxed; bh=NFJOufvQt8BD8lEftdSQx0McGoMPi5Wr6OjcZr1fq7A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R964zJu39o8asJcrF/hT/IhFmhSBm9EQjQGCpHTUSFLDUvslupCbRLjFmNfBj6EgdsklYk/zQ3LE+otgfFoJRM4hRga62h4wN9RkYPefpKdNDOROIv+wdMt2+9mVrMEIcDXLFHti2ZgxnWu0U2GbkpJZPYHpjacyJmBUSuhIihvBRGUx4GWOwiPMQHtwRzZXqKAi4XAr2IfU1n/zSXSLdBdqg4TQ+21HKYSK+raFRGWNHGf9y9vMzWliSJ5enq+xEuigi513ZcIjsWsj5ir2C7DgNju2fpNvC0HCIVtWSntfGgV9y4zJUBBndS4U41pc1jTerXDDu0jcAjufvIVyUw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=nCcPMvPN; dkim-atps=neutral; spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=nCcPMvPN; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=maddy@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4gVgRn3mzkz2xjN for ; Wed, 03 Jun 2026 18:12:52 +1000 (AEST) Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65370QAF3707938; Wed, 3 Jun 2026 08:12:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=NFJOuf vQt8BD8lEftdSQx0McGoMPi5Wr6OjcZr1fq7A=; b=nCcPMvPNXzjcBtHepmvH4V MAo37apCc7qk0E+K5O3E8r/GF6WzBFA9wAlFnm2CgNMTmLUnFdX1A1apCYiauuyE szMHAP3hbw5vJkJEIir9rwq02j89JJ1piXTz5mNuFWYBA5KO5IZPvrbTAGjxD8t5 YuRKDO7P0QbNh5R7Y3cDGqcQvWCkmuSITjKMmgJM9wbAqnvvvD17Be8sxZZMxBGw 2wi8EJ/Izc72AoyTHWzVIoNJU/1V3RIUwecvoOTCU6r7Zy1zZxAKOz9+/5q4y7vO W9rw3xQ0X5MBPIhFjaIbcKnCeo+yqMKSdkxKS5tEHSaeuj+pXPB7L4m14Qn5xY6Q == Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4efpae9ds3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 08:12:49 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 65389DQc000587; Wed, 3 Jun 2026 08:12:48 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4ega7qfe6h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Jun 2026 08:12:48 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 6538Cl5B54133194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 3 Jun 2026 08:12:47 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8666E5805E; Wed, 3 Jun 2026 08:12:47 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EAC415805F; Wed, 3 Jun 2026 08:12:43 +0000 (GMT) Received: from [9.43.74.208] (unknown [9.43.74.208]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 3 Jun 2026 08:12:43 +0000 (GMT) Message-ID: <66039318-07c0-4453-a295-bc39a2a5b8ec@linux.ibm.com> Date: Wed, 3 Jun 2026 13:42:42 +0530 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [SCSI] qla2xxx: Handle the INTx not connected while passing through To: Shivaprasad G Bhat , njavali@marvell.com, GR-QLogic-Storage-Upstream@marvell.com, James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, alex.williamson@nvidia.com, Kyle.Mahlkuch@ibm.com, linuxppc-dev References: <177885270578.1573.14283751510936407585.stgit@linux.ibm.com> Content-Language: en-US From: Madhavan Srinivasan In-Reply-To: <177885270578.1573.14283751510936407585.stgit@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=Zt3d7d7G c=1 sm=1 tr=0 ts=6a1fe201 cx=c_pps a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=5Kag_sxTX4npdQ8vrmgA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: DloX0hs752n9nOVtAfP7Ta6L2ag0gAsL X-Proofpoint-ORIG-GUID: DloX0hs752n9nOVtAfP7Ta6L2ag0gAsL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAzMDA3NiBTYWx0ZWRfXxeBod29K6jTk F2FkP4wRX9UZQn192C/W2D3oFLNfAJRmoFNABWBdG2rLNNS6GslV5r6mrojSl5kX9kUnRiw7pX9 nlIij5m72UTWGCLFuHGVT1nrHVWpnUKKTFiLJOqAkV4J5/sBplEaFe+ZCC6GmvJPmrXjx2n43v0 PJUWqIsGRmSwW3Lr2Cd2iQI8QDuDfzQnMVsiDFMHzY7SFPqDJ9p2kXq2vSi3+c9YrakWW9pQYrP MVxpapw7gAynJgVaDj3TVrz4bI3a+UKZYM3ha9rq09ctwy4TYgzUI9CHLO+01ECR0l8fMfXkBqq xa/5zccuWSGLjH0s/do2Sw4lSh9UODpprLMX5cd1Nu5Ci3ixZJ+aDiH5drL7kk9C7All9kOTHn2 vZUTjpBrDfjal81gCn86zzZN93XJ/5uL8/ADNa1441JkyOh7vZnHMomZmdqTQFlInzLBvd9ObQP yDc/M9YUSo31VgXvOVA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-03_03,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 priorityscore=1501 bulkscore=0 clxscore=1011 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606030076 On 5/15/26 7:15 PM, Shivaprasad G Bhat wrote: > The PCI_INTERRUPT_PIN reports if the device supports the INTx. > However, when the device is assigned to a guest via vfio, the > PCI_INTERRUPT_PIN is set to 0(i.e none) if the line is not > connected and|or the platform cannot route the interrupt. > > In such cases, the guest PCI_INTERRUPT_PIN is 0 and the port > number becomes -1(255, uint8_t underflow) for qla[25|27|28]xx and > qla2031 devices. The flt_region_nvram is never set, and subsequently > the lun detection fails. Below warnings show the NVRAM configuration > failure. > > []-0073:1: Inconsistent NVRAM checksum=0xffffffc0 id=HCAM version=0x100. > []-0074:1: Falling back to functioning (yet invalid -- WWPN) defaults. > []-0076:1: NVRAM configuration failed. > > The patch handles the case, and sets the port_no to devfn like > its done everywhere else. Any update on this? do you have any comments/concerns that should be addressed Maddy > Reference: commit 2bd42b03ab6b ("vfio/pci: Virtualize zero INTx PIN if no pdev->irq") > Signed-off-by: Shivaprasad G Bhat > --- > drivers/scsi/qla2xxx/qla_os.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c > index 72b1c28e4dae..a8d6a0a021f4 100644 > --- a/drivers/scsi/qla2xxx/qla_os.c > +++ b/drivers/scsi/qla2xxx/qla_os.c > @@ -2803,11 +2803,16 @@ qla2x00_set_isp_flags(struct qla_hw_data *ha) > else { > /* Get adapter physical port no from interrupt pin register. */ > pci_read_config_byte(ha->pdev, PCI_INTERRUPT_PIN, &ha->port_no); > - if (IS_QLA25XX(ha) || IS_QLA2031(ha) || > - IS_QLA27XX(ha) || IS_QLA28XX(ha)) > - ha->port_no--; > - else > - ha->port_no = !(ha->port_no & 1); > + if (ha->port_no == 0) { > + /* None of INT[A|B|C|D], may be virtualized by vfio */ > + ha->port_no = PCI_FUNC(ha->pdev->devfn); > + } else { > + if (IS_QLA25XX(ha) || IS_QLA2031(ha) || > + IS_QLA27XX(ha) || IS_QLA28XX(ha)) > + ha->port_no--; > + else > + ha->port_no = !(ha->port_no & 1); > + } > } > > ql_dbg_pci(ql_dbg_init, ha->pdev, 0x000b, > >