From: Milton Miller <miltonm@bga.com>
To: Andreas Schwab <schwab@suse.de>
Cc: ppcdev <linuxppc-dev@ozlabs.org>, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 2/2] fix showing xmon help
Date: Thu, 19 Jul 2007 00:50:22 -0500 [thread overview]
Message-ID: <664cbe49d76cfcba9d8a86e3a6946a2a@bga.com> (raw)
In-Reply-To: <je1wf5bshh.fsf@sykes.suse.de>
On Jul 18, 2007, at 11:12 AM, Andreas Schwab wrote:
> Milton Miller <miltonm@bga.com> writes:
>
>>> case '?':
>>> - printf(help_string);
>>> + xmon_puts(help_string);
>>> break;
>>>
>>
>> nonstdio.h #defines printf to xmon_printf. Please add a similar line
>> for puts, and use the define here. (It will avoid an unnecessary
>> difference with the user space version).
>
> User space puts add a newline, which this xmon_puts doesn't.
>
> Andreas.
Good point. This should be xmon_fputs #defined to fputs.
milton
next prev parent reply other threads:[~2007-07-19 5:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-18 9:26 [PATCH 2/2] fix showing xmon help Ishizaki Kou
2007-07-18 15:51 ` Milton Miller
2007-07-18 16:12 ` Andreas Schwab
2007-07-19 5:50 ` Milton Miller [this message]
2007-07-20 8:15 ` Ishizaki Kou
2007-07-23 6:49 ` Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=664cbe49d76cfcba9d8a86e3a6946a2a@bga.com \
--to=miltonm@bga.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).